Skip to content

Additional unit tests to UMDP3 checker #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
R Sharp (r-sharp) wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Additional unit tests to UMDP3 checker #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
009fd06
Adding unit tests for failures highlighted in #231
r-sharp Oct 19, 2026
c0159f5
Adding unit tests for failures highlighted in #235
r-sharp Oct 19, 2026
8429aab
Merge remote-tracking branch 'refs/remotes/origin/Additional_Unit_tes…
r-sharp Oct 19, 2026
06694e1
Signing CLA - cos I've not contributed until now ??????
r-sharp Oct 19, 2026
a45fa95
ruff format making things less readable again...
r-sharp Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
| james-bruten-mo | James Bruten | Met Office | 2026-09-10 |
| ericaneininger | Erica Neininger | Met Office | 2026-10-05 |
| t00sa | Sam Clarke-Green | Met Office | 2026-10-13 |
| r-sharp | R Sharp | Met Office | 2026-10-19 |
58 changes: 56 additions & 2 deletions script_umdp3_checker/tests/test_umdp3_rules_S3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ def test_r3_4_1_capitalised_keywords(
@pytest.mark.parametrize(
"changes_list, expected_result, expected_errors",
[
([], 0, {}), # No changes, expect no errors
(
[
[
Expand Down Expand Up @@ -485,16 +486,69 @@ def test_r3_4_1_capitalised_keywords(
0,
{},
), # Real world false Fail, Thanks Andy M.
([], 0, {}), # No changes, expect no errors
(
[
[
"add",
51,
["INTEGER, PARAMETER :: defaultsize = BIT_SIZE(0)/8"],
],
],
0,
{},
), # Curious real world fail from Sam
(
[
[
"add",
51,
["INTEGER, POINTER :: atm_global_points(:,:)=>NULL()"],
],
],
0,
{},
), # 2nd Curious real world fail from Sam
(
[
[
"add",
51,
[
"CHARACTER(LEN=30) :: ndg_filename_template(2)= ['unset','unset'"
],
],
],
0,
{},
), # Failure reported by Erica
(
[
[
"add",
51,
[
"REAL(KIND=real_umphys), INTENT(IN OUT) :: &",
"!",
" u( udims_s%i_start : udims_s%i_end, &",
],
],
],
0,
{},
), # Fun failure reported by Erica - comments intersprsed with multi-line declarations
],
ids=[
"No UpperCase Var Errors",
"2 UpperCase Var Errors",
"False FALSE error",
"5 UpperCase Var Errors on extended lines",
"Array dimnensions, twice on an extended line, but no failures",
"Array dimnensions, twice on an extended line, with one failure",
"Weird real world error from Andy M",
"No UpperCase Var Errors",
"Curious real world fail from Sam",
"2nd Curious real world fail from Sam",
"Failure reported by Erica",
"Fun failure reported by Erica - comments intersprsed with multi-line declarations",
],
)
def test_r3_4_2_no_full_uppercase_variable_names(
Expand Down
Loading