Repository navigation
Create Task screen: URL field - #260
Conversation
- Add URL field string resources to strings.xml. - Support errorText parameter in FoliaryTextField. - Add url and isUrlInvalid fields to CreateTaskViewData and handle URL normalization/validation in CreateTaskViewModel. - Add UrlField composable to CreateTaskScreen. - Add unit tests in CreateTaskViewModelTest, CreateTaskScreenTest, and FoliaryTextFieldTest. Closes #124
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Add URL field string resources to strings.xml. - Support errorText parameter in FoliaryTextField. - Add url and isUrlInvalid fields to CreateTaskViewData and handle URL normalization/validation in CreateTaskViewModel. - Add UrlField composable to CreateTaskScreen with correct import ordering. - Add unit tests in CreateTaskViewModelTest, CreateTaskScreenTest, and FoliaryTextFieldTest. Closes #124
Implemented URL field for Create Task screen (#124).
foliary/src/commonMain/composeResources/values/strings.xml.errorTextsupport toFoliaryTextField.CreateTaskViewModelandCreateTaskViewDatato support URL state, URL normalization (prefixinghttps://when scheme is missing and trimming whitespace), validation regex, and persistence.UrlFieldcomponent toCreateTaskScreenpositioned between description and priority picker.CreateTaskViewDataFixture,CreateTaskViewModelTest,CreateTaskScreenTest, andFoliaryTextFieldTest.Closes #124
PR created automatically by Jules for task 15667691275011409428 started by @MessiasLima