Skip to content

Object: do not include MRBox.h #6816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fedr merged 1 commit into from
Sep 9, 2026
Merged

Object: do not include MRBox.h #6816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/MRMesh/MRObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "MRObjectTagEventDispatcher.h"
#include "MRSerializer.h"
#include "MRStringConvert.h"
#include "MRBox.h"
#include "MRHeapBytes.h"
#include "MRphmap.h"
#include "MRPch/MRJson.h"
Expand Down Expand Up @@ -859,6 +860,11 @@ void Object::swap( Object& other )
swapSignals_( other );
}

Box3f Object::getWorldBox( ViewportId ) const
{
return {}; // empty box
}

Box3f Object::getWorldTreeBox( ViewportId id ) const
{
Box3f res = getWorldBox( id );
Expand Down
3 changes: 1 addition & 2 deletions source/MRMesh/MRObject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#pragma once

#include "MRAffineXf3.h"
#include "MRBox.h"
#include "MRExpected.h"
#include "MRProgressCallback.h"
#include "MRSignal.h"
Expand Down Expand Up @@ -244,7 +243,7 @@ class MRMESH_CLASS Object : public ObjectChildrenHolder
MRMESH_API void swap( Object& other );

/// returns bounding box of this object in world coordinates for default or specific viewport
virtual Box3f getWorldBox( ViewportId = {} ) const { return {}; } ///empty box
MRMESH_API virtual Box3f getWorldBox( ViewportId = {} ) const;
/// returns bounding box of this object and all children visible in given (or default) viewport in world coordinates
MRMESH_API Box3f getWorldTreeBox( ViewportId = {} ) const;

Expand Down
1 change: 1 addition & 0 deletions source/MRMesh/MRVisualObject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include "MRObject.h"
#include "MRBox.h"
#include "MRMeshTexture.h"
#include "MRVector.h"
#include "MRColor.h"
Expand Down
Loading