Object: hide fields from users - #6274
Draft
Fedr wants to merge 6 commits into
Draft
Conversation
Fedr
marked this pull request as draft
June 16, 2026 18:55
# Conflicts: # source/MRMesh/MRChangeValue.h # source/MRMesh/MRMeshFwd.h
The hand-written copy constructor only initialized ObjectChildrenHolder and data_, so name_, tags_, visibilityMask_, locked_, parentLocked_, selected_, ancillary_ and worldXfChangedSignal were default-initialized instead of copied: clone() dropped the name, tags and visibility of every object. The move constructor and move assignment likewise transferred only data_, which broke swapBase_ (std::swap of *this and other) into swapping just the xf, and left child parent_ pointers dangling. Wrap the pimpl in DataPtr, a unique_ptr<Data> with value semantics, so all of Object's copy and move operations go back to = default and keep copying every base and member, as the ObjectChildrenHolder comment intends.
# Conflicts: # source/MRMesh/MRObject.cpp # source/MRMesh/MRObject.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.