Repository navigation
fix(frontend): make the dashboard build pass again (26 type errors since April) - #319
Conversation
…nce April) The frontend build gate added on 2026-09-23 (166091b) has failed on every main run since: five April PRs left code that never compiled — imports of shadcn components that were never added (ui/alert, ui/textarea), seven example widgets that never existed (CustomElementHost), react-router-dom (not a dependency), a useSSE call written for a different hook, a wrong ChatMessages prop set, and unused locals under noUnusedLocals. - add the standard shadcn alert and textarea components - CustomElementHost: empty registry instead of imports of missing widgets - useWindowMessage: small local EventSource hook for /sse/window-message - SharedThread: read the token from /shared/{token}; pass the props ChatMessages takes; type messages as ChatMessage[] - drop unused imports/locals None of these files are imported by the app today, so nothing users see changes; the gate now builds and catches real breakage again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@claude You are the FINAL architecture reviewer. If the branch is under MervinPraison/PraisonAIUI (not a fork), you are able to make modifications to this branch and push directly. SCOPE: Focus ONLY on PraisonAIUI (src/praisonaiui, src/frontend, tests, docs). Do NOT expand into praisonaiagents or the monorepo unless the PR explicitly requires it. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding. Phase 1: Review per AGENTS.md
Phase 2: FIX Valid Issues Phase 3: Final Verdict |
Final architecture review: approve, no changes pushedReviewer feedback: none to act on. Copilot did not run because of a quota limit, and Gemini, Qodo and CodeRabbit left no comments. I reviewed the diff myself. Checks against AGENTS.md
Verified locally (on
Files modified by this review: none. Skipped, not blocking
Verdict: ready to merge. |
Root cause of the red
frontendcheck onmain, on every run since 2026-09-23.That day
166091badded a frontend build gate (npm run build, i.e.tsc -b && vite build). Five PRs from April (#33, #34, #35 and two smaller ones) had left code that had never been compiled in CI, so the new gate failed on every run. The last green CI onmainisb151143, from 23 Sep. Every open PR inherits the red check, including #318.The 26 errors and their fixes:
components/ui/alertandui/textareaimported but never addedcva/@/lib/utilsstyle as the others)CustomElementHostlazy-imports 7 example widgets that never existeduseWindowMessagecallsuseSSE(url, {onMessage...}), but this package'suseSSEis the chat streaming storeEventSourcehook for the existing/sse/window-messageendpointSharedThreadusesreact-router-dom, which is not a dependency, and the wrongChatMessagesprops/shared/{token}(the routeserver.pyserves), pass the propsChatMessagestakes, type messages asChatMessage[]noUnusedLocalsNone of these files are imported by the app today, so nothing users see changes. The point is that the gate builds again, so it can catch real breakage.
Verified locally:
npm ci && npm run buildnow exits 0; onmainit exits 2.npm test: 8/8 pass.🤖 Generated with Claude Code