Skip to content

ci: bump github-automation-template to v1.1.19 - #315

Merged
MervinPraison merged 1 commit into
mainfrom
bump-template-v1.1.19
Oct 26, 2026
Merged

MervinPraison merged 1 commit into
mainfrom
bump-template-v1.1.19

Conversation

@MervinPraison

Copy link
Copy Markdown
Owner

Bumps the github-automation-template pins from v1.1.18 to v1.1.19.

v1.1.19 makes outsider flagging precise: an outsider run's window now ends when its Claude job ends, and only content changes or gate-loosening label changes by the App count. Routine label syncing and other runs' activity no longer flag unrelated PRs. A writer removing origin/outsider clears a wrong flag. No permission or input changes (checked against v1.1.18).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 10:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@MervinPraison
MervinPraison merged commit 6c15699 into main Oct 26, 2026
16 of 17 checks passed
@MervinPraison

Copy link
Copy Markdown
Owner Author

@claude You are the FINAL architecture reviewer. If the branch is under MervinPraison/PraisonAIUI (not a fork), you are able to make modifications to this branch and push directly. SCOPE: Focus ONLY on PraisonAIUI (src/praisonaiui, src/frontend, tests, docs). Do NOT expand into praisonaiagents or the monorepo unless the PR explicitly requires it. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding.

Phase 1: Review per AGENTS.md

  1. Protocol-driven: check heavy implementations vs core SDK
  2. Backward compatible: ensure zero feature regressions
  3. Performance: no hot-path regressions (lazy imports, import-time <200ms)
  4. Product value: review in depth whether the change genuinely adds PraisonAIUI UX value — never add features for the sake of adding them. It must strengthen the UI (simpler, more user-friendly, robust). If it does not clearly add value, request changes or recommend rejecting/closing rather than merging scope creep.
  5. Layering: UI/frontend/server features here; core agent runtime belongs in praisonaiagents (PraisonAI monorepo). Agent-callable tools → PraisonAI-Tools. Do not pull monorepo or SDK scope into this repo unless the PR explicitly requires it.
  6. Do not bloat server.py or create_app() with new params — prefer existing YAML config, plugins, and feature modules; only add params if absolutely required. Reject knobs/exports with no live consumer.

Phase 2: FIX Valid Issues
5. For any VALID bugs or architectural flaws found by Gemini, CodeRabbit, Qodo, Copilot, or any other reviewer: implement the fix
6. Push all code fixes directly to THIS branch (do NOT create a new PR)
7. Comment a summary of exact files modified and what you skipped

Phase 3: Final Verdict
8. If all issues are resolved, approve the PR / close the Issue
9. If blocking issues remain, request changes / leave clear action items

@praisonai-triage-agent

Copy link
Copy Markdown
Contributor

Final architecture review — PR #315 (template v1.1.18 → v1.1.19)

Verdict: ✅ Approve / safe to merge. I made no code changes, so nothing was pushed.

What I checked

  • Pin consistency: all 7 caller workflows now use @v1.1.19 for both uses: and hub_ref:. No v1.1.18 references are left in .github/workflows/.
  • Tag exists: MervinPraison/github-automation-template@v1.1.19 resolves to d3248d5.
  • Permission and input contract: I diffed the 6 reusable workflows (review-chain, bot-pr-recovery, ci-failure-claude, claude-merge-gate, claude-assistant, pipeline-status-sync) between v1.1.18 and v1.1.19. Only 6 lines changed, and none touch permissions:, inputs: or required fields. The caller permission blocks are still enough, which matches the PR description.
  • Scope / AGENTS.md: CI-only. Nothing changes in src/praisonaiui, src/frontend, tests or docs. No new params, dependencies or exports, no runtime or import-time effect, and no UX regression.

Reviewer feedback

  • Copilot could not review (out of quota). There were no Gemini, Qodo or CodeRabbit findings to act on.

CI

  • python (3.10/3.11/3.12): pass.
  • frontend: fails, but the failure already exists on main. These are tsc errors in src/chat/*, src/hooks/useWindowMessage.ts and src/pages/SharedThread.tsx (for example, missing modules ../components/ui/alert and react-router-dom). The last 3 main runs fail the same way. This PR doesn't touch them, so I left them alone to keep the scope tight; they should be fixed in a separate PR.

Files modified

None.

Skipped

  • The frontend TypeScript build errors: out of scope here and already broken on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants