Repository navigation
test: targeted-auth coverage for milestones::recover_admin (#562) - #759
Open
Chidi-Dev1 wants to merge 1 commit into
Open
Chidi-Dev1 wants to merge 1 commit into
Chidi-Dev1 wants to merge 1 commit into
Conversation
mock_all_auths() was the only call exercising recover_admin, which means neither the recovery.require_auth() nor the new_admin.require_auth() inside the function were ever actually checked. Add three targeted-auth tests that replace that gap: - test_recover_admin_requires_both_recovery_and_new_admin_auth_ok: both MockAuth entries present -> succeeds, admin slot updated. - test_recover_admin_rejects_recovery_only: recovery signs but new_admin does not -> host auth error, admin unchanged. - test_recover_admin_rejects_new_admin_only: new_admin signs but recovery does not -> host auth error, admin unchanged. Each test uses env.mock_auths() with the exact fn_name and args tuple so the Soroban host actually enforces the require_auth() calls. Closes MergeFi#562. Regression on MergeFi#314.
|
@Chidi-Dev1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Chidi-Dev1 is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #562. Regression on #314.
recover_adminrequires bothrecovery.require_auth()andnew_admin.require_auth()— but the only existing call was undermock_all_auths(), so neither check was ever exercised by tests.Changes
Three new targeted-auth tests in
contracts/milestones/src/test.rs:test_recover_admin_requires_both_recovery_and_new_admin_auth_oktest_recover_admin_rejects_recovery_onlytest_recover_admin_rejects_new_admin_onlyEach test uses
env.mock_auths()with exactfn_nameand args tuple so the Soroban host actually enforces therequire_auth()calls rather than bypassing them.Testing
All 3 pass. No other files changed.