Repository navigation
Conversation
|
@DeFex-lab is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@DeFex-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes
@typescript-eslint/unbound-methodlint errors in the GitHub controller specs, where unbound method references were passed toexpect(). The offending assertions are replaced withjest.spyOn-based references sonpm run lintcan pass while keeping the rule enabled.Related Issue
Changes
🧪 Controller Spec Fixes
[MODIFY]
src/github/github.controller.spec.tsexpect(controller.sync)-style references at lines 62 and 71 withjest.spyOn-based assertions, so the method is referenced through a bound spy rather than an unbound prototype method.[MODIFY]
src/github/github-webhooks.controller.spec.tsjest.spyOn-based assertion, consistent with the fix in the other spec.Verification Results
unbound-methoderrors atgithub.controller.spec.ts:62and:71are resolvedjest.spyOnunbound-methoderror atgithub-webhooks.controller.spec.ts:142is resolvedjest.spyOn@typescript-eslint/unbound-methodrule is kept enabledCloses #606