Repository navigation
fix: specs for money validator, webhook payload, rate limits on public reads, and relations loading - #712
Merged
chonilius merged 1 commit intoOct 20, 2026
Conversation
…c reads, and relations loading Closes MergeFi#603 Closes MergeFi#595 Closes MergeFi#592 Closes MergeFi#591
|
@meloball9993-star Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@meloball9993-star is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the 4 issues assigned to @meloball9993-star:
src/common/validators/money.validator.spec.tstesting 7-decimal boundaries, rejection of 8 decimals, 0, leading zeros, 100M cap, and stroops roundtrip.src/github/github-webhook-payload.util.spec.tstesting minimal valid payloads, missing required fields, and incorrect property types for PR and issue webhooks.@Throttlelimits on public read endpoints (GET /bounties/:id,GET /milestones/:id,GET /maintenance-pools,GET /maintenance-pools/:id) to prevent database resource exhaustion.repositoryandissuesrelation loading inMilestonesService.listandrepositoryinMaintenancePoolService.listandfindOne.Closes #603
Closes #595
Closes #592
Closes #591