Repository navigation
fix(config): validate numeric env vars at boot and fail fast (#610) - #623
Open
urielit1313-creator wants to merge 1 commit into
Open
urielit1313-creator wants to merge 1 commit into
urielit1313-creator wants to merge 1 commit into
Conversation
|
@urielit1313-creator is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
urielit1313-creator
force-pushed
the
fix/validate-numeric-env-610
branch
from
October 20, 2026 11:51
2d77b80 to
d020d8c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #610.
Summary of Changes
parsePositiveIntegerEnv(value, defaultValue, varName)insrc/config/configuration.tsto strictly validate positive integers for:PORT(default3000)ANALYTICS_PLATFORM_SUMMARY_TTL_MS(default60000)ESCROW_DEADLINE_SECONDS(default7776000)90d), negative value, zero, or decimal is configured, preventing downstreamRangeError: cannot convert NaN to BigIntruntime crashes during escrow funding.collectConfigIssuesinsrc/config/validate-required-config.tsto explicitly ensureescrowDeadlineSecondsis a positive integer when booting in production.src/config/numeric-config.spec.tscovering parsing, edge cases, boot failure scenarios, and production config assertion.Verification
npm test src/config/numeric-config.spec.ts: 9/9 tests passing (100% pass).npx eslint src/config/configuration.ts src/config/validate-required-config.ts src/config/numeric-config.spec.ts: 0 errors, 0 warnings.Payout address (Base USDC):
0xfE777c43e4B0A24fFA1527eD520d1E7f9ECED483