Fix loadSwiftData fileExists path / URL-string mismatch#7
Open
ShoootingStaR693 wants to merge 1 commit into
Open
Fix loadSwiftData fileExists path / URL-string mismatch#7ShoootingStaR693 wants to merge 1 commit into
ShoootingStaR693 wants to merge 1 commit into
Conversation
23b53f1 to
2b21404
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDWallpaperVideo.videoURL/.previewImageare stored asURL.absoluteString(file://…), butloadSwiftData()checked themwith
FileManager.fileExists(atPath:), which expects a plain path.The check always returned false, so every launch entered the recovery
branch and read the
@Attribute(.externalStorage)video/thumbnailproperties. Effects:
.mov/.pngper launch.@Attribute(.externalStorage)on every launch exposes theapp to a CoreData
NSException(_PFRoutines readBytesForExternalReferenceData:→
_crashOnException) whenever an external blob is missing orunreadable.
Fix: extract
URL.pathfrom the stored string beforefileExists.