Skip to content

Add python docs package update script - #314

Open
davidhorstmann-arm wants to merge 5 commits into
Mbed-TLS:mainfrom
davidhorstmann-arm:add-python-package-update-script
Open

Add python docs package update script#314
davidhorstmann-arm wants to merge 5 commits into
Mbed-TLS:mainfrom
davidhorstmann-arm:add-python-package-update-script

Conversation

@davidhorstmann-arm

Copy link
Copy Markdown
Contributor

Add a small script to update the Python packages used to generate the docs in Mbed TLS.

PR checklist

Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.

  • TF-PSA-Crypto development PR not required because: New script only
  • TF-PSA-Crypto 1.1 PR not required because: New script only
  • mbedtls development PR not required because: New script only
  • mbedtls 4.1 PR not required because: New script only
  • mbedtls 3.6 PR not required because: New script only

This installs pip-tools and runs pip-compile on docs/requirements.in to
regenerate docs/requirements.txt with the latest versions of things.

Note: This script was originally created in the Mbed TLS repository and
will need rework to fit in the framework.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
Ensure the script is being run from the Mbed TLS root using the project
detection code from the framework.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
If docs/requirements.txt is unchanged by the update, do not attempt to
make a commit.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
Since `python --version` seems to output the major, minor and patch
versions, we can safely just check for the second dot character.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members. needs-reviewer This PR needs someone to pick it up for review labels Jul 9, 2026
Ensure we don't try to commit an update that doesn't exist due to
errors, or similar.

Signed-off-by: David Horstmann <david.horstmann@arm.com>

@yiwu0b11 yiwu0b11 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i'm not sure why is the CI failing, seems unrelated.

Info: Test case was ignored: test_suite_config.crypto_combinations;Config: entropy: NV seed only
--
  |   |   | Error: Test case not executed: test_suite_psa_crypto;PSA generate key custom: RSA, e=3 with driver and no fallback (not yet supported)
  |   |   | Error: Test case not executed: test_suite_psa_crypto_driver_wrappers;PSA decrypt transparent driver: fallback not available RSA OAEP-SHA-256
  |   |   | Error: Test case not executed: test_suite_psa_crypto_driver_wrappers;PSA decrypt transparent driver: fallback not available RSA PKCS#1 v1.5
  |   |   | Error: Test case not executed: test_suite_psa_crypto_driver_wrappers;PSA encrypt transparent driver: fallback not available RSA OAEP-SHA-256
  |   |   | Error: Test case not executed: test_suite_psa_crypto_driver_wrappers;PSA encrypt transparent driver: fallback not available RSA PKCS#1 v1.5
  |   |   | Error: Test case not executed: test_suite_psa_crypto_driver_wrappers;PSA encrypt-decrypt transparent driver: fallback not available RSA OAEP-SHA-256
  |   |   | Error: Test case not executed: test_suite_psa_crypto_driver_wrappers;PSA encrypt-decrypt transparent driver: fallback not available RSA PKCS#1 v1.5
  |   |   | Info: Overall results: 0 warnings and 7 errors

@davidhorstmann-arm

Copy link
Copy Markdown
Contributor Author

It looks like there were a couple of infrastructure issues. One of them hit the component that tests RSA acceleration and the result analysis detected it as a test case not executed. I'm going to give it a poke and see if that works.

@gilles-peskine-arm gilles-peskine-arm added priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d) and removed needs-reviewer This PR needs someone to pick it up for review labels Jul 20, 2026

@gilles-peskine-arm gilles-peskine-arm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I don't understand the exclusion of TF-PSA-Crypto

Comment on lines +9 to +12
if is_tf_psa_crypto_root $PWD; then
echo "Error: This script is only for Mbed TLS"
exit 1
fi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why shouldn't this script run in TF-PSA-Crypto?

@github-project-automation github-project-automation Bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Jul 20, 2026
@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members. labels Jul 20, 2026
@gilles-peskine-arm

Copy link
Copy Markdown
Contributor

The CI failed for another intermittent reason. I'm leaving up to you to either rerun the CI and merge, or update to remove the repository restriction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)

Projects

Development

Successfully merging this pull request may close these issues.

3 participants