Skip to content

generate_test_cert_macros.py: Removed absolute path from the rendered output - #313

Open
minosgalanakis wants to merge 1 commit into
Mbed-TLS:mainfrom
minosgalanakis:tools/fix-auto-generated-files
Open

generate_test_cert_macros.py: Removed absolute path from the rendered output#313
minosgalanakis wants to merge 1 commit into
Mbed-TLS:mainfrom
minosgalanakis:tools/fix-auto-generated-files

Conversation

@minosgalanakis

@minosgalanakis minosgalanakis commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

As part of the post release activities, fixing minor inconveniences of the tooling required to build a release.

This pr adjust the generate_test_cert_macros.py logic to use relative paths BEFORE rendering the templates for the auto-generated files but continue using absolute paths internally so it can be called from different locations in the tree.

Needs to be tested locally with ./framework/scripts/generate_test_cert_macros.py and inspection of the header files.

PR checklist

Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.

  • TF-PSA-Crypto development PR not required because: script contained here
  • TF-PSA-Crypto 1.1 PR not required because: script contained here
  • mbedtls development PR not required because: script contained here
  • mbedtls 4.1 PR not required because: script contained here
  • mbedtls 3.6 PR not required because: script contained here

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis minosgalanakis added needs-review Every commit must be reviewed by at least two team members. needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-low Low priority - this may not receive review soon size-xs Estimated task size: extra small (a few hours at most) labels Jul 9, 2026
@bjwtaylor
bjwtaylor self-requested a review July 10, 2026 07:48
@bjwtaylor
bjwtaylor self-requested a review July 10, 2026 08:02

@bjwtaylor bjwtaylor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but there is a ci failure that will need to be resolved.

@ronald-cron-arm

Copy link
Copy Markdown
Contributor

Why do you mention make_generated_files.py here where it is about scripts/generate_test_cert_macros.py?

@ronald-cron-arm

Copy link
Copy Markdown
Contributor

Otherwise could you clean-up the PR description? Remove the "Notes for the submitter", update the PR checklist.

@minosgalanakis

Copy link
Copy Markdown
Contributor Author

Why do you mention make_generated_files.py here where it is about scripts/generate_test_cert_macros.py?

Because generate_test_cert_macros is called by make_generated_files, but yes you are right it could be more specific.

Also the CI failure is the typical intermitten ssl one, restarted

@ronald-cron-arm

Copy link
Copy Markdown
Contributor

Why do you mention make_generated_files.py here where it is about scripts/generate_test_cert_macros.py?

Because generate_test_cert_macros is called by make_generated_files, but yes you are right it could be more specific.

Please update the title and PR description accordingly.

@ronald-cron-arm ronald-cron-arm removed their assignment Jul 10, 2026
@ronald-cron-arm
ronald-cron-arm self-requested a review July 10, 2026 14:53
@ronald-cron-arm ronald-cron-arm added needs-work and removed needs-reviewer This PR needs someone to pick it up for review needs-ci Needs to pass CI tests labels Jul 10, 2026

@ronald-cron-arm ronald-cron-arm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minosgalanakis minosgalanakis changed the title make_generated_files.py: Removed absolute path from the rendered output generate_test_cert_macros.py: Removed absolute path from the rendered output Jul 13, 2026

@gilles-peskine-arm gilles-peskine-arm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a fix for that in #231. Let's not spend more time making a second one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Every commit must be reviewed by at least two team members. priority-low Low priority - this may not receive review soon size-xs Estimated task size: extra small (a few hours at most)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants