generate_test_cert_macros.py: Removed absolute path from the rendered output - #313
generate_test_cert_macros.py: Removed absolute path from the rendered output#313minosgalanakis wants to merge 1 commit into
Conversation
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
bjwtaylor
left a comment
There was a problem hiding this comment.
The changes look good but there is a ci failure that will need to be resolved.
|
Why do you mention make_generated_files.py here where it is about scripts/generate_test_cert_macros.py? |
|
Otherwise could you clean-up the PR description? Remove the "Notes for the submitter", update the PR checklist. |
Because generate_test_cert_macros is called by make_generated_files, but yes you are right it could be more specific. Also the CI failure is the typical intermitten ssl one, restarted |
Please update the title and PR description accordingly. |
ronald-cron-arm
left a comment
There was a problem hiding this comment.
See #313 (comment)
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
There is already a fix for that in #231. Let's not spend more time making a second one.
Description
As part of the post release activities, fixing minor inconveniences of the tooling required to build a release.
This pr adjust the generate_test_cert_macros.py logic to use relative paths BEFORE rendering the templates for the auto-generated files but continue using absolute paths internally so it can be called from different locations in the tree.
Needs to be tested locally with
./framework/scripts/generate_test_cert_macros.pyand inspection of the header files.PR checklist
Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.