Test data for failure caused by empty digest algorithm - #302
Conversation
bjwtaylor
changed the title
b1b62f1 to
b3bc2ec
Compare
bjwtaylor
added
needs-review
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
b3bc2ec to
97ef810
Compare
valeriosetti
left a comment
valeriosetti
left a comment
There was a problem hiding this comment.
Usually each data file in this folder has an associated make rule in the Makefile. This helps in case in the future the file has to be re-generated for some reason.
I don't know how you get these files, but do you think it should be possible to do this?
There was a problem hiding this comment.
Given the description provided in Mbed-TLS/mbedtls#10480 should we want to have something similar to pkcs7_empty_digest.der but with some CRT in it?
Probably this doesn't change anything compared to pkcs7_empty_digest.der, but it would be something close to some real use case. Wdyt?
Sorry perhaps that's already covered from pkcs7_data_cert_signed_sha256_empty_digest.der 🤔
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
|
@valeriosetti, I've added a section to the makefile. |
2 participants
Description
Test data for failure caused by empty digest algorithm. contributes Mbed-TLS/mbedtls#10480.
Parameterised build https://ci.trustedfirmware.org/view/Mbed-TLS/job/mbed-tls-restricted-pr-test-parametrized/176/
This PR is part of a two part set which must be merged in the following order:
PR checklist