Build/windows aether fetch helper - #23
Open
Nishef1 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a first-class PowerShell helper for fetching the pinned Aether core on Windows and reuse that helper in the Windows build job.
This removes duplicated inline download logic from CI and gives Windows contributors the same one-command, checksum-verified setup path already available to Linux/macOS contributors.
Problem
The repository currently has a reusable Unix fetch helper, while Windows setup is split between:
That duplication makes the Windows local-development and release-build paths easier to drift apart.
Changes
src-tauri/binaries/fetch-aether.ps1v1.3.0)SHA256SUMS.txtaether.exe, so failed downloads/checks do not overwrite the existing binary.github/workflows/build.ymlwith the helper callWhy
The same core-preparation logic should be reusable by local development and CI. Keeping checksum verification in one Windows helper reduces duplicated release plumbing and makes clean Windows setup less error-prone.
Scope
This is build/setup tooling only. It does not introduce runtime core updates, change the pinned Aether version, or modify any tunnel/protocol behavior.
Validation
mainat9ba2ef0: four focused files changedPowerShell was not available in the connector environment used to prepare this branch, so the helper has not been executed there. Please run the repository checks and exercise
fetch-aether.ps1on Windows before marking the PR ready.