Build/verify bundled aether resource - #20
Open
Nishef1 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fail the build early when the Aether executable is missing/empty or when the Tauri resource configuration no longer includes the binaries directory.
Problem
A desktop bundle can otherwise progress into packaging with a broken core-resource setup and only fail later on a clean machine, where the application cannot resolve the bundled Aether binary.
Because the release workflow already fetches the core before packaging, this is a natural point to assert the packaging contract explicitly.
Changes
scripts/verify-bundled-aether.mjsaether.exeon Windows,aetherelsewhere)src-tauri/tauri.conf.jsonand verifybundle.resourcescontainsbinaries/*npm run verify:bundled-aetherWhy
This converts a clean-machine runtime failure into a deterministic build-time failure with a direct error message. It also guards against accidental changes to the Tauri resource glob that would silently stop shipping the core.
Scope
This PR only validates the existing bundled-core contract. It does not change how the core is downloaded, selected, executed, or updated.
Validation
mainat9ba2ef0: three focused files changednode --check scripts/verify-bundled-aether.mjs: passed in an equivalent fixturebundle.resources: ["binaries/*"]: passedThe full repository checks were not executable from the connector environment. Also note that this branch independently touches
build.yml; if the Windows fetch-helper PR merges first, rebase this branch onto the new upstreammainbefore submitting/merging it.