Serial ports redirected to vscode Output tab#1218
Open
simonsso wants to merge 2 commits intoMarus:masterfrom
Open
Serial ports redirected to vscode Output tab#1218simonsso wants to merge 2 commits intoMarus:masterfrom
simonsso wants to merge 2 commits intoMarus:masterfrom
Conversation
Author
|
I think this is a great feature, but I am not a typescript developer so the code could probably be improved and rewritten. My scope was only qemu but maybe there are more usecases in this extension which could use the same mechanisms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch creates a named pipe for each serial port needed. Appends the same numer of -serial args to qemu and the then redirects that output to a tab in Output for vscode.
Parts of this commit is written using AI tools.