[aaltat]

Summary

Node only, no proto change. A follow-up to #5318 and #5326, and the second step of moving the
registration of adopted contexts into Browser (#5369 was the first).

adoptContext now does two things that every extension had to do itself:

 extensionKeywordCall
   adoptContext(context, options)
-    _indexContextWithPages(context, undefined, ...)
+    _indexContextWithPages(context, <defaultTimeout of the call>, ...)
-    return { browserId, contextId, pageId }
+    return { browserId, contextId, pageId, videoPath }   # video of the active page, or null

 async function openAdoptedPersistentContext(..., playwright, adoptContext) {
     ...
-    context.setDefaultTimeout(defaultTimeout);
     return adoptContext(context, { onClose });

Connect To Browser indexed the pages that already exist in the connected browser without their
close listener (#5368). It now indexes each page through _newPage; the last page stays active,
as before:

 addBrowser
   for each context
-    pageStack = context.pages().map(indexedPage)          # no close listener
+    _createIndexedContext(context)
+    for each page not yet indexed
+      pageStack.push(_newPage(context, page))             # removes itself on close

New Context on a persistent or adopted browser says so:

-Trying to create a new context when a persistentContext is active
+Cannot create a new context in chromium, because its context is persistent or adopted. Open a new browser first.

Fixes #5368

Evidence

• Before: connected over CDP to a Chromium with one open page, closed that page from its own
  browser, then Switch Browser to the connected one:
  page.bringToFront: Target page, context or browser has been closed.
  After: the closed page leaves the page stack; Get Page Ids returns [].
• New Jest tests, each red before its change:
  • an adopted context gets the default timeout of the call
  • adoptContext returns the video path of the active page; null without video or pages
  • addBrowser removes a page that existed when the browser was connected once it closes
  • addBrowser indexes a page once when the context reports it while the browser is added
  • New Context on an adopted browser explains why it fails
• Acceptance: the test extension no longer sets the timeout nor reads the video path, so
  An Adopted Context Gets The Library Timeout and the recording tests from test: pin the video size of an adopted context through a library built on Browser #5369 now cover both
  through the extension call. 05_JS_Tests 61/61; 01_Browser_Management passes except two
  Firefox tests whose browser fails to launch locally (CI runs them).

Merge Danger

Door: two-way

Blast Radius: Connect To Browser

adoptContext is unreleased, so its changes reach no users. Connect To Browser is released: a
closed page that existed at connect time no longer stays in the catalog or stays the active page.
The changed error message of New Context breaks a test that matches the old text.

🤖 Generated with Claude Code