Repository navigation
test: guard the adopted context options and video sizes before unifying them - #5358
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Compare adopted_context_options with the recordVideo, recordHar and trace file that New Context sends for the same arguments, so the two cannot drift apart. New Context with an empty recordVideo records into the video folder, and a registered adopted context embeds its video in the log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
get_trace_group_titles and its siblings are used by suites in two folders, so they belong with the other shared Python keywords. Their annotations now say that get_file_line can return None. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The video tests used the 1280x720 default, which is also what the size falls back to without a viewport or size, so dropping either at any call site went unnoticed. New Context, New Persistent Context and a registered adopted context now each show they cache the size of their viewport, or the size given, and the embedded video uses it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aaltat
force-pushed
the
adopted-context-tests
branch
from
October 17, 2026 17:35
f5dab48 to
a0253b3
Compare
aaltat
marked this pull request as ready for review
October 17, 2026 17:35
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests only, no production code. Follow-up to #5326 and #5356.
The next PR unifies how the three routes work out the video size (
_video_sizeat three call sites). The old tests all used 1280x720, which is also the fallback without a viewport or size, so they could not catch a call site that dropped either.Evidence
_video_size(...)call site with_video_size(None, None)leaves every test green.After: it fails that route's
..._caches_its_video_size[viewport]and[size](and the embed test forregister_adopted_context). Bypassing_record_videoor_record_haron theNew Contextroute fails the comparison test.utest/test_adopted_context.py: 37 passed;inv utest: 850 passed.inv atest --suite "Tracing Groups"and"Adopted Context Recording": passed with the moved helper.Merge Danger
Door: two-way
Blast Radius: none
Tests and an acceptance-test helper only.
🤖 Generated with Claude Code