Repository navigation
test: characterize the generated JavaScript extension keyword - #5352
Merged
Merged
Conversation
Pin how the generated keyword reads a streamed result, sends its varargs, takes its defaults from the JavaScript signature and sends a Test scoped timeout, before it is changed to call call_js_keyword. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests only, no production code. They pin what Python sends to Node and how it reads the reply for a generated JavaScript extension keyword, before a follow-up changes the generated keyword to call
call_js_keywordand letscall_js_keywordfilldefaultTimeoutwhen the caller leaves it out (follow-up to #5318, #5321).The tests sit at the Python seam:
utest/test_js_extension_call.pywith a stub that recordsCallExtensionKeyword. The repeated setup became pytest fixtures.Not tested on purpose: a reply carrying
json. Node builds every extension response withjsonResponse('', ...), so thelast_jsonbranch can't be reached; the follow-up removes it.Evidence
[], so no unit test read a reply;*args, JS defaults and a Test scoped timeout were covered only by acceptance tests or not at all (NaN/Infinity).After:
pytest utest/test_js_extension_call.py: 9 passed. Breaking the join, theNonereturn,*args, the NaN conversion or the timeout in_jskeyword_callfails the six new tests.Merge Danger
Door: two-way
Blast Radius: none
Unit tests only; nothing ships to users.
🤖 Generated with Claude Code