Repository navigation
Accept fps and showActions in recordVideo, convert adopted context options like New Context - #5347
Merged
Merged
Conversation
RecordVideo declared only dir and size, so New Context and New Persistent Context rejected Playwright's fps and showActions options. Closes MarketSquare#5346 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adopted_context_options passed recordVideo, recordHar and viewport on as given, so the values were not converted and unknown keys were kept, unlike New Context. They now go through the same Robot Framework conversion as the arguments of New Context, and AdoptedContextOptions types recordVideo and recordHar as RecordVideo and RecordHar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The New Context docstring now points to RecordVideo for the new video options, and the failure test of adopted_context_options sends the deprecated showActions.fontSize, which RecordVideo leaves out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aaltat
force-pushed
the
record-video-show-actions
branch
from
October 17, 2026 11:47
57fad3f to
7066ce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecordVideogets Playwright 1.64'sfpsandshowActions, soNew ContextandNew Persistent Contextaccept them.adopted_context_optionsconverts its arguments likeNew Context, follow-up to #5326.The deprecated
showActions.fontSizeis not declared;style.titlereplaces it.positionandcursorare(str, Enum), becauseStrEnumneeds Python 3.11; JSON gets the plain values.Closes #5346
Evidence
test_new_context_sends_frame_rate_and_action_annotations,test_new_persistent_context_sends_action_annotations,test_video_options_are_converted_like_new_context,test_deprecated_font_size_fails_like_new_context, and the acceptance testCreate Video With Action Annotations And Frame Rate.inv utest(835 passed), and theVideo,Adopt ContextandAdopted Context Recordingsuites pass.Merge Danger
Door: two-way
adopted_context_optionsfrom #5326 is not released yet, so making it strict changes nothing users have.Blast Radius: small
Libraries built on
adopted_context_options, such as the Electron library, now fail on keysRecordVideodoes not declare, for exampleshowActions.fontSize.New Contextonly gains keys.🤖 Generated with Claude Code