Repository navigation
chore: trim adoptContext comments and docstring - #5344
Merged
Merged
Conversation
Follow-ups to MarketSquare#5318: - Remove code comments that repeat the jsextension docstring. - Shorten the adoptContext part of the jsextension docstring and point to the JavaScript extension guide for its options. - Remove the docstring from the unit test helper. - Set the timeout in the unit test through Set Browser Timeout instead of writing scope_stack directly (ADR 0009). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #5318.
playwright-state.tsandbrowser.pythat repeat thejsextensiondocstring. Two one-line comments stay where the reason is not visible in the code.adoptContextpart of thejsextensiondocstring and point to the JavaScript extension guide for its options and examples (robotframework-browser.org#21).RecordingPlaywrightunit test helper.test_generated_keyword_reads_the_library_timeout_at_each_callthroughset_browser_timeoutinstead of writingscope_stackdirectly (ADR 0009).The
defaultTimeoutwording in the docstring is unchanged; that is still being decided.Tested locally:
inv utest --suite utest/test_js_extension_call.py(4 passed),inv lint-python,inv lint-node, andinv atest --suite adopt_contextafterinv node-build(3 passed).🤖 Generated with Claude Code