Repository navigation
docs: drop outdated language registration step - #155
Merged
Merged
Conversation
get_language() discovers languages from the translation_<language>.json files, so there is nothing to register in __init__.py. The only manual step left is EXPECTED_LANGUAGES in utest/test_translation.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 4 of "Add A New Language" in the README told contributors to register the language in
get_language(). That is no longer needed:get_language()discovers languages from the shippedtranslation_<language>.jsonfiles. The step now points toEXPECTED_LANGUAGESinutest/test_translation.py, the only place still edited by hand (as the Tip section already says).This also triggers a fresh release run, since the v2.2.1 tag push failed on GitHub's side in run 39033374377.
🤖 Generated with Claude Code