Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates official MarkEdit extension/theme registry entries from raw.githubusercontent.com tag URLs to GitHub Release asset download URLs so downloads are counted and assets are validated against releases.
Changes:
- Updated extension/theme
urlfields to GitHub Release asset URLs across the registry (andindex.json/ README examples). - Added
releaseAssetURL()helper and integrated it intoscripts/update-official.mjsto resolve release asset URLs from release metadata. - Added a unit test covering release-asset lookup behavior.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| themes/markedit-theme-vscode.json | Switches theme version URLs to GitHub Release asset downloads. |
| themes/markedit-theme-tokyo-night.json | Switches theme version URLs to GitHub Release asset downloads. |
| themes/markedit-theme-quietlight.json | Switches theme version URLs to GitHub Release asset downloads. |
| themes/markedit-theme-one-dark.json | Switches theme version URLs to GitHub Release asset downloads. |
| themes/markedit-theme-nord.json | Switches theme version URLs to GitHub Release asset downloads. |
| themes/markedit-theme-noctis-lilac.json | Switches theme version URLs to GitHub Release asset downloads. |
| themes/markedit-theme-gruvbox.json | Switches theme version URLs to GitHub Release asset downloads. |
| themes/markedit-theme-duotone.json | Switches theme version URLs to GitHub Release asset downloads. |
| themes/markedit-theme-catppuccin.json | Switches theme version URLs to GitHub Release asset downloads. |
| themes/markedit-theme-basic.json | Switches theme version URLs to GitHub Release asset downloads. |
| extensions/markedit-ai-writer.json | Switches extension version URL to GitHub Release asset download. |
| extensions/markedit-devtools.json | Switches extension version URLs to GitHub Release asset downloads. |
| extensions/markedit-enhanced-paste.json | Switches extension version URLs to GitHub Release asset downloads. |
| extensions/markedit-highlight.json | Switches extension version URL to GitHub Release asset download. |
| extensions/markedit-language-data.json | Switches extension version URLs to GitHub Release asset downloads. |
| extensions/markedit-mindmap.json | Switches extension version URLs to GitHub Release asset downloads. |
| extensions/markedit-mte.json | Switches extension version URL to GitHub Release asset download. |
| extensions/markedit-prettier.json | Switches extension version URLs to GitHub Release asset downloads. |
| extensions/markedit-preview.json | Switches extension version URLs to GitHub Release asset downloads. |
| extensions/markedit-quick-emoji.json | Switches extension version URLs to GitHub Release asset downloads. |
| extensions/markedit-reference-style-links.json | Switches extension version URL to GitHub Release asset download. |
| extensions/markedit-theme-zero.json | Switches extension version URLs to GitHub Release asset downloads. |
| extensions/markedit-vim.json | Switches extension version URL to GitHub Release asset download. |
| index.json | Updates latest.url entries to GitHub Release asset downloads. |
| scripts/release-url.mjs | Adds releaseAssetURL() helper for locating assets by name. |
| scripts/update-official.mjs | Uses releaseAssetURL() when deriving official URLs from release metadata. |
| test/release-url.test.mjs | Adds unit test for release asset URL resolution. |
| README.md | Updates documentation/examples to prefer GitHub Release asset URLs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've updated all GitHub releases to include a
.jsfile in the assets.When review, the main job is to ensure their existence.