Repository navigation
feat(s3): direct s3 download with manifest-based dedup (~12x speedup) - #92
Merged
Merged
Conversation
Download artifacts directly from R2/S3 using temporary credentials Falls back to the legacy download path when the api returns 404 (runs without a manifest). - Add rust-s3 dependency for S3-compatible direct downloads - New download_v2 module: streaming downloads with 64 concurrency, 3-attempt retry, and manifest link handling - Handle manifest links: symlinks on Unix, file copy on Windows - Apply v2 path to both `download` and `run --output` flows Benchmark on 35k-file run: Before: ~51 min After: ~4 min 20s
rust-s3 0.37.x pins quick-xml ^0.38 with no upstream fix available yet. Exposure is limited to parsing S3 error responses from R2, not attacker-controlled input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download artifacts directly from R2/S3 using temporary credentials Falls back to the legacy download path when the api returns 404 (runs without a manifest).
downloadandrun --outputflowsBenchmark on 35k-file run:
Before: ~51 min After: ~4 min 20s