Add segmented sliding-window storage - #65
Conversation
Malkovsky
commented
Aug 31, 2026
- Updated storage API to return array of two spans rather then single span
- Introduced sliding window storage
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27d7b3cd1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| position_type begin_position() const { return impl().begin_position_impl(); } | ||
|
|
||
| /** @brief Return the position one past the last logical byte exposed. */ | ||
| position_type end_position() const { return impl().end_position_impl(); } |
There was a problem hiding this comment.
Document the new storage extension-point requirements
Add canonical Doxygen contracts for begin_position_impl(), end_position_impl(), and both segments_impl() variants. The facade now requires these hooks—and serialization depends on them—but only documents the public wrappers, leaving implementers without the required invariants for absolute positions, range validation, segment ordering, and lifetime/invalidation behavior. Concrete-class comments do not replace the CRTP extension-point contract.
AGENTS.md reference: AGENTS.md:L86-L92
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 90.66% 90.96% +0.30%
==========================================
Files 47 49 +2
Lines 12220 12395 +175
Branches 1771 1778 +7
==========================================
+ Hits 11079 11275 +196
+ Misses 533 518 -15
+ Partials 608 602 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|