Repository navigation
Conversation
unused fucn and better check for max/min ME
no H>D D>H coppies, still umami init and coppies
Qubitol
self-requested a review
October 15, 2026 16:03
Contributor
|
Would it not make sense to keep those transfer time? |
Contributor
Author
|
The times for the copy D>H and H>D are still available, however now the ME time does not involve the copy itself, which is closer to what production event generation would be like (data already on GPU and because of unweighting small portion of events generated copied to host) Before: After: For heavy processes the time difference is negligible as the copy is Now thinking about it we may change the name of the timer as it no longer times the SigmaKin but the whole umami call (corresponding to production) so:
(v100, g g > t t~ g g, ./check_sa -p 256 256 1) |
Also rather timermap then extra var
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timing without D>H H>D copy
Also silencing of standalone warning with clang