feature/invasion spawn table configuration#757
feature/invasion spawn table configuration#757eduardosmaniotto wants to merge 13 commits intoMUnique:masterfrom
Conversation
# Conflicts: # src/Web/Shared/Components/Form/MultiLookupField.razor.cs # src/Web/Shared/Properties/Resources.Designer.cs # src/Web/Shared/Properties/Resources.resx
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the invasion event system to be data-driven rather than hardcoded. By introducing configurable spawn tables, admins gain granular control over monster spawns, map distribution, and spawn strategies. The changes also improve event reliability by adding duration-based overlap prevention and more robust cleanup mechanisms, while providing a new UI component for easier configuration management. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the invasion event system to support flexible monster spawn configurations, including random map selection and coordinate generation. Key improvements include O(1) random walkable point lookups in GameMapTerrain, a centralized configuration system for invasions, and enhanced state management to prevent overlapping events. The review feedback identifies a concurrency issue with the _cleanupHandlers list and suggests reordering the state reset logic to prevent stale data from triggering redundant messages or spawns when an event run is skipped.
If you don't want to manually create default values, you can delete the plugin configuration and restart the server to recreate them: