You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add support for european dates in header files. - #550
I'm not sure if this is violating the spec, but it should be fairly unambiguous with this date format (moreso than the d/m/y format, which might be interpreted as m/d/y).
Thanks for this! The WFDB header format only allows the base date as DD/MM/YYYY, and the WFDB library ignores a date in any other form (rdsamp -pd shows no date for a header with 25.04.1989), so accepting DD.MM.YYYY here would make the two read the same file differently. Closing for that reason.
Perhaps we should consider supporting ISO 8601 dates (YYYY-MM-DD) in future. That would need changes to the WFDB library and the format specification too, though, so it's not something we'd add here on its own. Please feel free to open an issue if you'd like to discuss this further.
For anyone following this: there is now a draft proposal for a JSON header syntax, which uses ISO 8601 dates (YYYY-MM-DD), in wfdb/wfdb-spec#25. Comments are welcome there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modeled after
wfdb_strptime(directly above).I'm not sure if this is violating the spec, but it should be fairly unambiguous with this date format (moreso than the
d/m/yformat, which might be interpreted asm/d/y).