Repository navigation
feat: [glimps_malware] add analysis lookup and sample submission #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # GLIMPS Malware Enrichment | ||
|
|
||
| Retrieve GLIMPS Detect results by SHA-256 or analysis UUID supplied as text. Set api_url to the service HTTPS origin. Supplied samples are hashed and looked up first. submit_samples defaults to false; true permits submitting a previously unknown sample. max_size_mb defaults to 25 (1–100). Submission returns an analysis UUID for later text lookup. Provider verdicts and analysis details are retained in a sandbox-report object. The access token for an expert view is excluded from imported report data. | ||
|
|
||
| Input: sha256, text, attachment, malware-sample. | ||
|
|
||
| Configuration: api_url, api_token, submit_samples, max_size_mb. Required: api_url, api_token. | ||
|
|
||
| New attributes use `to_ids=false`; the source UUID, detection flag and metadata are preserved. Objects reference the source attribute. Requests verify TLS, reject redirects and use connection/read timeouts of 5/30 seconds. API errors do not echo credentials. No automatic submission retries or background polling occur. | ||
|
|
||
| Reference: https://github.com/glimps-re/py-gdetect | ||
|
|
||
| One complete provider report is retained per lookup; there is no result-count setting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,269 @@ | ||
| import base64 | ||
| import hashlib | ||
| import io | ||
| import ipaddress | ||
| import json | ||
| import re | ||
| import zipfile | ||
| from urllib.parse import quote, urlsplit | ||
| from uuid import UUID | ||
| import requests | ||
| from pymisp import MISPEvent, MISPObject | ||
| from pymisp.exceptions import PyMISPError | ||
|
|
||
|
|
||
| class ModuleError(ValueError): | ||
| """A diagnostic safe to show to the analyst.""" | ||
|
|
||
|
|
||
| def _integer(config, key, default, maximum=100): | ||
| value = config.get(key) | ||
| if value is None or value == "": | ||
| return default | ||
| if isinstance(value, bool) or not str(value).isdigit() or (not 1 <= int(value) <= maximum): | ||
| raise ModuleError(f"{key} must be an integer between 1 and {maximum}.") | ||
| return int(value) | ||
|
|
||
|
|
||
| def _enabled(config, key, default=False): | ||
| value = config.get(key) | ||
| if value is None or value == "": | ||
| return default | ||
| if isinstance(value, bool): | ||
| return value | ||
| if str(value).lower() not in ("true", "false", "1", "0"): | ||
| raise ModuleError(f"{key} must be true or false.") | ||
| return str(value).lower() in ("true", "1") | ||
|
|
||
|
|
||
| def _url(value): | ||
| if not isinstance(value, str) or any(ord(c) <= 32 or ord(c) == 127 for c in value): | ||
| raise ModuleError("Invalid HTTPS URL.") | ||
| parsed = urlsplit(value) | ||
| if parsed.scheme != "https" or not parsed.hostname or parsed.username or parsed.password or parsed.fragment: | ||
| raise ModuleError("An HTTPS URL without credentials or fragment is required.") | ||
| parsed.port | ||
| return value.rstrip("/") | ||
|
|
||
|
|
||
| def _origin(config): | ||
| value = _url(config.get("api_url", "")) | ||
| if urlsplit(value).query: | ||
| raise ModuleError("api_url cannot contain a query string.") | ||
| return value | ||
|
|
||
|
|
||
| def _segment(value): | ||
| return quote(str(value), safe="") | ||
|
|
||
|
|
||
| def _normalise(kind, value): | ||
| if not isinstance(value, str) or not value.strip() or any(ord(c) < 32 for c in value): | ||
| raise ModuleError("A nonempty string value is required.") | ||
| value = value.strip() | ||
| if kind in ("md5", "sha1", "sha256", "x509-fingerprint-sha256"): | ||
| length = {"md5": 32, "sha1": 40}.get(kind, 64) | ||
| if not re.fullmatch("[a-fA-F0-9]{%d}" % length, value): | ||
| raise ModuleError("Invalid hash.") | ||
| return value.lower() | ||
| if kind in ("ip-src", "ip-dst"): | ||
| return str(ipaddress.ip_address(value)) | ||
| if kind in ("domain", "hostname"): | ||
| value = value.rstrip(".").encode("idna").decode("ascii").lower() | ||
| if len(value) > 253 or not all( | ||
| re.fullmatch("[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?", p) for p in value.split(".") | ||
| ): | ||
| raise ModuleError("Invalid DNS name.") | ||
| if kind == "vulnerability": | ||
| value = value.upper() | ||
| if not re.fullmatch("CVE-[0-9]{4}-[0-9]{4,}", value): | ||
| raise ModuleError("A CVE identifier is required.") | ||
| return value | ||
|
|
||
|
|
||
| def _call(method, url, **kwargs): | ||
| try: | ||
| response = requests.request(method, url, timeout=(5, 30), verify=True, allow_redirects=False, **kwargs) | ||
| except requests.RequestException: | ||
| raise ModuleError( | ||
| "The service request failed or timed out; check the service before repeating a submission." | ||
| ) from None | ||
| if response.status_code in (204, 404) and method == "GET": | ||
| return None | ||
| if response.status_code not in (200, 201, 202): | ||
| raise ModuleError(f"The service returned HTTP {response.status_code}.") | ||
| try: | ||
| return response.json() | ||
| except ValueError: | ||
| raise ModuleError("The service returned invalid JSON.") from None | ||
|
|
||
|
|
||
| def _object(event, attribute, name): | ||
| obj = MISPObject(name) | ||
| obj.add_reference(attribute["uuid"], "describes") | ||
| event.add_object(obj) | ||
| return obj | ||
|
|
||
|
|
||
| def _annotation(event, attribute, title, data): | ||
| obj = _object(event, attribute, "annotation") | ||
| obj.comment = title | ||
| obj.add_attribute("text", value=json.dumps(data, sort_keys=True), to_ids=False, disable_correlation=True) | ||
| return obj | ||
|
|
||
|
|
||
| def _pivot(event, attribute, kind, value): | ||
| value = _normalise(kind, value) | ||
| if kind == attribute["type"] and value == _normalise(attribute["type"], attribute["value"]): | ||
| return | ||
| obj = _object( | ||
| event, attribute, "file" if kind in ("md5", "sha1", "sha256") else ("url" if kind == "url" else "domain-ip") | ||
| ) | ||
| relation = "ip" if kind in ("ip-src", "ip-dst") else kind | ||
| obj.add_attribute(relation, value=value, to_ids=False) | ||
|
|
||
|
|
||
| def _sandbox(event, attribute, payload, link=None): | ||
| obj = _object(event, attribute, "sandbox-report") | ||
| obj.add_attribute("sandbox-type", value="on-premise", to_ids=False) | ||
| obj.add_attribute("on-premise-sandbox", value="glimps-detect", to_ids=False) | ||
| obj.add_attribute("results", value=json.dumps(payload, sort_keys=True), to_ids=False, disable_correlation=True) | ||
| if link: | ||
| obj.add_attribute("permalink", value=link, to_ids=False) | ||
| return obj | ||
|
|
||
|
|
||
| def _binary(attribute, config): | ||
| limit = _integer(config, "max_size_mb", 25, 100) * 1024 * 1024 | ||
| encoded = attribute.get("data") | ||
| if not isinstance(encoded, str) or len(encoded) > 2 * limit: | ||
| raise ModuleError("Missing or oversized base64 sample data.") | ||
| content = base64.b64decode(encoded, validate=True) | ||
| filename = attribute["value"] | ||
| if attribute["type"] == "malware-sample": | ||
| filename, separator, digest = filename.rpartition("|") | ||
| if not separator or not re.fullmatch(r"[a-fA-F0-9]{32}", digest): | ||
| raise ModuleError("A malware-sample value must contain filename|md5.") | ||
| with zipfile.ZipFile(io.BytesIO(content)) as archive: | ||
| entries = [ | ||
| e for e in archive.infolist() if not e.is_dir() and e.filename != digest.lower() + ".filename.txt" | ||
| ] | ||
| if len(entries) != 1 or entries[0].file_size > limit: | ||
| raise ModuleError("A malware-sample archive must contain one payload within max_size_mb.") | ||
| content = archive.read(entries[0], pwd=b"infected") | ||
| if hashlib.md5(content).hexdigest() != digest.lower(): | ||
| raise ModuleError("The unpacked sample does not match the declared MD5.") | ||
| filename = filename.replace("\\", "/").rsplit("/", 1)[-1] | ||
| if not filename or not content or len(content) > limit: | ||
| raise ModuleError("The sample is empty or exceeds max_size_mb.") | ||
| return filename, content, hashlib.sha256(content).hexdigest() | ||
|
|
||
|
|
||
| def handler(q=False): | ||
| if q is False: | ||
| return False | ||
| try: | ||
| request = json.loads(q) | ||
| if not isinstance(request, dict) or not isinstance(request.get("attribute"), dict): | ||
| raise ModuleError("An attribute containing type, value and uuid is required.") | ||
| attribute = request["attribute"] | ||
| UUID(attribute["uuid"]) | ||
| if attribute["type"] not in mispattributes["input"]: | ||
| raise ModuleError("Unsupported attribute type.") | ||
| value = _normalise(attribute["type"], attribute["value"]) | ||
| config = request.get("config") or {} | ||
| if not isinstance(config, dict): | ||
| raise ModuleError("The config must be an object.") | ||
| for key in REQUIRED: | ||
| if not isinstance(config.get(key), str) or not config[key].strip(): | ||
| raise ModuleError(f"Missing {key} configuration.") | ||
| limit = 25 | ||
| event = MISPEvent() | ||
| event.add_attribute(**attribute) | ||
| _expand(event, attribute, value, config, limit) | ||
| result = json.loads(event.to_json()) | ||
| return {"results": {key: result.get(key, []) for key in ("Attribute", "Object")}} | ||
| except ModuleError as exc: | ||
| return {"error": str(exc)} | ||
| except ( | ||
| ValueError, | ||
| TypeError, | ||
| KeyError, | ||
| AttributeError, | ||
| IndexError, | ||
| OSError, | ||
| RuntimeError, | ||
| zipfile.BadZipFile, | ||
| PyMISPError, | ||
| ): | ||
| return {"error": "Invalid request or service response."} | ||
|
|
||
|
|
||
| def introspection(): | ||
| return mispattributes | ||
|
|
||
|
|
||
| def version(): | ||
| return dict(moduleinfo, config=moduleconfig) | ||
|
|
||
|
|
||
| moduleinfo = { | ||
| "version": "1.0", | ||
| "author": "MISP Project", | ||
| "name": "GLIMPS Malware Enrichment", | ||
| "description": ( | ||
| "Retrieve GLIMPS Detect results by SHA-256 or analysis UUID supplied as text. Set api_url to the service HTTPS" | ||
| " origin. Supplied samples are hashed and looked up first. submit_samples defaults to false; true permits" | ||
| " submitting a previously unknown sample. max_size_mb defaults to 25 (1–100). Submission returns an analysis" | ||
| " UUID for later text lookup. Provider verdicts and analysis details are retained in a sandbox-report object." | ||
| " The access token for an expert view is excluded from imported report data." | ||
| ), | ||
| "module-type": ["expansion"], | ||
| "data-source": "external", | ||
| "logo": "", | ||
| "requirements": ["requests", "pymisp"], | ||
| "features": ( | ||
| "Retrieve GLIMPS Detect results by SHA-256 or analysis UUID supplied as text. Set api_url to the service HTTPS" | ||
| " origin. Supplied samples are hashed and looked up first. submit_samples defaults to false; true permits" | ||
| " submitting a previously unknown sample. max_size_mb defaults to 25 (1–100). Submission returns an analysis" | ||
| " UUID for later text lookup. Provider verdicts and analysis details are retained in a sandbox-report object." | ||
| " The access token for an expert view is excluded from imported report data." | ||
| ), | ||
| "references": ["https://github.com/glimps-re/py-gdetect"], | ||
| "input": "sha256, text, attachment, malware-sample", | ||
| "output": "MISP objects linked to the original attribute.", | ||
| } | ||
| mispattributes = {"input": ["sha256", "text", "attachment", "malware-sample"], "format": "misp_standard"} | ||
| moduleconfig = ["api_url", "api_token", "submit_samples", "max_size_mb"] | ||
| REQUIRED = ["api_url", "api_token"] | ||
|
|
||
|
|
||
| def _expand(event, attribute, value, config, limit): | ||
| base = _origin(config) | ||
| api = base + "/api/lite/v2" | ||
| headers = {"X-Auth-Token": config["api_token"]} | ||
| sample = None | ||
| if attribute["type"] in ("attachment", "malware-sample"): | ||
| sample = _binary(attribute, config) | ||
| value = sample[2] | ||
| if attribute["type"] == "text": | ||
| UUID(value) | ||
| path = "/results/" + _segment(value) | ||
| else: | ||
| path = "/search/" + value | ||
| data = _call("GET", api + path, headers=headers) | ||
| if data is None and sample and _enabled(config, "submit_samples"): | ||
| receipt = _call("POST", api + "/submit", headers=headers, files={"file": (sample[0], sample[1])}) | ||
| if not isinstance(receipt, dict) or not receipt.get("uuid"): | ||
| raise ModuleError("GLIMPS did not acknowledge the submission; check the service before retrying.") | ||
| _annotation(event, attribute, "GLIMPS submission receipt", {"uuid": receipt["uuid"], "sha256": sample[2]}) | ||
| return | ||
| if data is None: | ||
| return | ||
| if not isinstance(data, dict): | ||
| raise ModuleError("GLIMPS returned invalid analysis data.") | ||
| payload = {key: item for key, item in data.items() if key != "token"} | ||
| if payload: | ||
| _sandbox(event, attribute, payload) | ||
| if isinstance(payload.get("sha256"), str): | ||
| _pivot(event, attribute, "sha256", payload["sha256"]) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an analyst configures
max_results, the handler validates and passes it here, but_expandnever readslimit; the complete provider payload is always serialized into the sandbox report. Consequently evenmax_results=1has no effect on responses containing large result collections, contrary to the exposed and documented configuration. Apply the limit to imported result collections or remove the ineffective option.Useful? React with 👍 / 👎.