Repository navigation
feat: [greynoise_vuln] add dedicated CVE intelligence lookups - #1062
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78fd620ec8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| limit = _integer(config, "max_results", 25) | ||
| event = MISPEvent() | ||
| event.add_attribute(**attribute) | ||
| _expand(event, attribute, value, config, limit) |
There was a problem hiding this comment.
When an operator configures max_results, the parsed value is passed to _expand, but _expand never reads limit and always stores the complete response in one annotation. Consequently every accepted value from 1 through 100 produces identical output, despite the module metadata and documentation exposing this as a result cap; either remove the setting or apply it to the generated enrichment.
Useful? React with 👍 / 👎.
A CVE attribute can retrieve the dedicated GreyNoise vulnerability API response, including available exploitation activity, exploit statistics and prioritization fields. The referenced annotation preserves zero and false values. Missing records do not become benignness assertions. Subscription-dependent coverage is documented.
Includes a usage guide and focused adapter tests.
Validation:
19 passed, 1 warning in 0.75swithpytest -q tests/test_greynoise_vuln.py; flake8 passed for the module. The combined enrichment regression check passed 389 tests.Authenticated provider API validation remains pending. Tests use sanitized fixtures; no provider credentials are included.
Review updates: Remove the ineffective max_results setting; each lookup retains one complete provider report.
Updated validation: 19 passed, 1 warning in 0.72s; module lint passed. Combined regression validation passed 409 tests.