Repository navigation
feat: [dnslytics] add domain dataset searches - #1061
Merged
Merged
Conversation
adulau
marked this pull request as ready for review
October 29, 2026 22:10
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit text query retrieves the first page of the DNSlytics domain dataset. Results preserve active/dropped observations and source references, cap imported domains, and report truncation using the provider ndomains field. Documentation describes premium credit consumption and the absence of additional DNS or ASN lookups.
Includes a usage guide and focused adapter tests.
Validation:
19 passed, 1 warning in 0.65swithpytest -q tests/test_dnslytics.py; flake8 passed for the module. The combined enrichment regression check passed 389 tests.Authenticated provider API validation remains pending. Tests use sanitized fixtures; no provider credentials are included.
Review updates: Normalize the source consistently before pivot deduplication and add a regression check for valid URL objects.
Updated validation: 20 passed, 1 warning in 0.63s; module lint passed. Combined regression validation passed 409 tests.