Skip to content

Workaround elimination with latest amdflang drop and Removing array reshapes#1433

Open
anandrdbz wants to merge 14 commits into
MFlowCode:masterfrom
anandrdbz:master
Open

Workaround elimination with latest amdflang drop and Removing array reshapes#1433
anandrdbz wants to merge 14 commits into
MFlowCode:masterfrom
anandrdbz:master

Conversation

@anandrdbz
Copy link
Copy Markdown
Contributor

@anandrdbz anandrdbz commented May 12, 2026

Description

This PR consists of 4 major tasks:

  1. Replacing older version of amdflang compiler with the latest drop
  2. Ensuring all test cases pass with the new drop
  3. Removing dummy variable workaround with case-optimization
  4. Eliminating array reshapes for better overall simulation times

Fixes #(issue)

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other: describe

Testing

How did you test your changes?

Checklist

  • I added or updated tests for new behavior
  • I updated documentation if user-facing behavior changed

See the developer guide for full coding standards.

GPU changes (expand if you modified src/simulation/)
  • GPU results match CPU results
  • Tested on NVIDIA GPU or AMD GPU

AI code reviews

Reviews are not triggered automatically. To request a review, comment on the PR:

  • @coderabbitai review — incremental review (new changes only)
  • @coderabbitai full review — full review from scratch
  • /review — Qodo review
  • /improve — Qodo code suggestions
  • @claude full review — Claude full review (also triggers on PR open/reopen/ready)
  • Add label claude-full-review — Claude full review via label

@anandrdbz anandrdbz requested a review from sbryngelson as a code owner May 12, 2026 17:38
@qodo-code-review
Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@sbryngelson sbryngelson marked this pull request as draft May 12, 2026 17:44
@sbryngelson sbryngelson removed their request for review May 12, 2026 17:48
@sbryngelson
Copy link
Copy Markdown
Member

it has merge conflicts already...

@anandrdbz
Copy link
Copy Markdown
Contributor Author

It's a very minor conflict in CMake from a change yesterday, I will resolve it

@github-actions

This comment was marked as resolved.

@sbryngelson sbryngelson marked this pull request as ready for review May 12, 2026 23:39
@qodo-code-review
Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

sbryngelson
sbryngelson previously approved these changes May 12, 2026
…elocation error

flang-23/LLD defaults to building PIE executables. SILO and LAPACK static
libraries on Frontier are compiled without -fPIC, so their 32-bit absolute
relocations (R_X86_64_32) are rejected by LLD when linking a PIE binary.
Add -no-pie to post_process link options for LLVMFlang to allow non-PIC
system libraries. simulation is unaffected (no SILO/LAPACK dependency).
sbryngelson
sbryngelson previously approved these changes May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 88.40580% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.00%. Comparing base (28863b1) to head (dbf6aec).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_muscl.fpp 42.85% 16 Missing ⚠️
src/simulation/m_rhs.fpp 81.25% 6 Missing and 3 partials ⚠️
src/simulation/m_viscous.fpp 76.92% 0 Missing and 3 partials ⚠️
src/simulation/m_weno.fpp 98.56% 0 Missing and 2 partials ⚠️
src/simulation/m_cbc.fpp 0.00% 0 Missing and 1 partial ⚠️
src/simulation/m_time_steppers.fpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage   64.95%   65.00%   +0.04%     
==========================================
  Files          72       72              
  Lines       18879    18810      -69     
  Branches     1571     1553      -18     
==========================================
- Hits        12263    12227      -36     
+ Misses       5640     5615      -25     
+ Partials      976      968       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants