Workaround elimination with latest amdflang drop and Removing array reshapes#1433
Workaround elimination with latest amdflang drop and Removing array reshapes#1433anandrdbz wants to merge 14 commits into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
it has merge conflicts already... |
|
It's a very minor conflict in CMake from a change yesterday, I will resolve it |
This comment was marked as resolved.
This comment was marked as resolved.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
…elocation error flang-23/LLD defaults to building PIE executables. SILO and LAPACK static libraries on Frontier are compiled without -fPIC, so their 32-bit absolute relocations (R_X86_64_32) are rejected by LLD when linking a PIE binary. Add -no-pie to post_process link options for LLVMFlang to allow non-PIC system libraries. simulation is unaffected (no SILO/LAPACK dependency).
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
+ Coverage 64.95% 65.00% +0.04%
==========================================
Files 72 72
Lines 18879 18810 -69
Branches 1571 1553 -18
==========================================
- Hits 12263 12227 -36
+ Misses 5640 5615 -25
+ Partials 976 968 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR consists of 4 major tasks:
Fixes #(issue)
Type of change
Testing
How did you test your changes?
Checklist
See the developer guide for full coding standards.
GPU changes (expand if you modified
src/simulation/)AI code reviews
Reviews are not triggered automatically. To request a review, comment on the PR:
@coderabbitai review— incremental review (new changes only)@coderabbitai full review— full review from scratch/review— Qodo review/improve— Qodo code suggestions@claude full review— Claude full review (also triggers on PR open/reopen/ready)claude-full-review— Claude full review via label