FIX: Full resname matching for nucleic acid analysis#5365
Open
BradyAJohnston wants to merge 3 commits intoMDAnalysis:developfrom
Open
FIX: Full resname matching for nucleic acid analysis#5365BradyAJohnston wants to merge 3 commits intoMDAnalysis:developfrom
BradyAJohnston wants to merge 3 commits intoMDAnalysis:developfrom
Conversation
BradyAJohnston
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5365 +/- ##
===========================================
- Coverage 93.85% 93.84% -0.01%
===========================================
Files 182 182
Lines 22499 22499
Branches 3200 3200
===========================================
- Hits 21117 21115 -2
- Misses 921 922 +1
- Partials 461 462 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orbeckst
approved these changes
Apr 23, 2026
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix!
orbeckst
requested changes
Apr 23, 2026
Member
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
code is great but need CHANGELOG entry, especially as it has potential for code breakage
Member
Author
|
I had already added to the changelog but just hadn't pushed it from my local machine 😅 |
Member
Author
|
I don't know if it should be 'louder' or more obvious in the changelog given it's a potentially breaking change? If you have a better way to include in feel free to just suggest / merge the chanage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5360
I had a surface level look (searching for similar code) and couldn't find any other usage of this - so it should be the only occurrence. Tests were previously passing because of the bug and have now been fixed. Could cause issues if users were relying on this bug but still worth fixing ASAP.
Changes made in this Pull Request:
resname[0]->resnameas put forward in the issueLLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5365.org.readthedocs.build/en/5365/