Repository navigation
Add Vibrational Density of States (VDoS) widget - #119
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
Documentation build overview
11 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in this Pull Request:
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
PR Checklist
cc: @HeydenLabASU , @amruthesht
Given
mdadashnow has weights support for ACF (as part of PR #112), I added support for showing VDoS calculated from the mass weighted VACF. I used HeydenLabASU-collab/trvdos as a reference for this implementation.The values are a match to the ones from
trvdos. Here are more details about the comparisons:topol.tprandtraj.trr- 1001 framestrvdosdata, I used thedevtools/examples/example.ipynbnotebook with the above input filesmdadashis run with the same topology and trajectory filesmdadashshows normalized values for both VACF and VDoSFirst, here are the VACF comparisons for different selections:
trvdosmdadashproteinresid 1resid 100:115Here are the VDoS comparisons for the above selecitons:
trvdosmdadashproteinresid 1resid 100:115A few notes about the data above:
trvdosstarts calculating VACF after the window is full (if(tStep>=nCorr-1) {), where asmdadashaccounts for the lags from the very first frame - there could be very minor differences due to thismdadashuses normalized (to 1) values for VDoS and the normalization for VACF is configurable in the widget (enabled for plots above)mdadashVACF widget to be comparable totrvdos, the new VDoS widget implicitly uses mass weighting for the VACFtrvdoshas an issue with arbitrary selections - see Arbitrary selections do not work and lead to memory corruption HeydenLabASU-collab/trvdos#11mdadashallows arbitrary selections)@HeydenLabASU , @amruthesht, I'd be happy to update this if you think any other changes are needed here. Thanks