frameworks/kemal: add benchmark implementation - #1174
Open
nigrosimone wants to merge 2 commits into
Open
Conversation
nigrosimone
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
August 15, 2026 19:21
Owner
|
/benchmark --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework: No results captured Full log |
Owner
|
/benchmark --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
|
|
Owner
|
/benchmark --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework: No results captured Full log |
Contributor
Author
|
The failed run is the build on the benchmark host, not the entry logic: shards install crashes the crystal compiler with "Unhandled exception: Arithmetic overflow (OverflowError)". The same build passes the validate runner, which has 4 CPUs, and the benchmark host reports 128 available CPUs, exactly one past what an Int8 holds, so a cpu count kept in a too-small integer somewhere in the toolchain is the suspect. A workaround worth trying in the Dockerfile is bounding the affinity of the two build steps, taskset -c 0-63 for both shards install and crystal build. If the built server reads the cpu count at runtime the same way, it may need the same cap when it starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Kemal, and with it Crystal, which is not on the board at all.
Six profiles: baseline, pipelined, limited-conn, json, json-comp, upload.
Verified locally: docker build, then the six profiles replayed against this repo's own
data/dataset.json, byte identical to express and fastify for the same requests.Written with Claude Opus 5.