Open
Conversation
added 3 commits
April 17, 2026 14:58
In order to use supervisor-daemon, it is required to only use the default start(), stop(), and status() functions. Reference: https://github.com/OpenRC/openrc/blob/master/supervise-daemon-guide.md
$MAINPID is used by systemd. It does not look like OpenRC uses it, or even sets it. The reload() function is fixed by using the Gentoo example for `acpid`. It requires a `pidfile`. Reference: https://wiki.gentoo.org/wiki/OpenRC/supervise-daemon#Instructions_per_service
Set log files to the standard logging location. This helps administration since the log files will be located in the standard logging folder along with any reverse proxies and/or any other services that are needed to run MCSManager.
|
Someone is attempting to deploy a commit to the unitwk's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit has two fixes, and an improvement.
Fix 1:
The
stop()function can't be used withsupervisor-daemon, sincesupervisor-daemonrequires the default start, stop, and status functions.If the
stop()function is left as is, it will fail to actually stop eithermcsmd, ormcsmw(or rather either node processes running the web UI and daemon) whenopen-rc mcsmd/mcsmw stopis run. Monitoring the system's running processes withtop/htop/btop, or similar, when trying to stop either will show that they still run even after the stop command was issued.Simply removing the
stop()function fixes this issue. Usingopen-rc mcsmd/mcsmw stopwill work just fine sincesupervisor-daemonuses the default stop function.Fix 2:
The lines that use
/bin/kill -s $SOME_SIGNAL $MAINPIDfail to find aPIDto send a signal to, since OpenRC does not use$MAINPIDlike systemd does and is left unset as a result. This was fixed by using thereload()function example from the Gentoo wiki.The improvement:
The location for log files were added. This is helpful since it puts them in the standard logging folder location; this will make them easier to find and in close proximity to logs for reverse proxies, or any other administrative tools needed to run MCSManager.