Server list featured - #140
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR transitions the app from a “partner servers” view to a fuller server directory experience (list + detail), adds user reporting UI, and removes legacy Java-mode and chat/messaging functionality while keeping presence tracking via a dedicated WebSocket service.
Changes:
- Add server directory models/services and wire featured server surfaces to open a server detail page.
- Introduce a “Report user” bottom sheet and update feedback success flow to route users to in-app ticket viewing.
- Remove Java mode, partner server screens/cards, and messaging/chat services; replace presence tracking with a standalone PresenceService.
Reviewed changes
Copilot reviewed 70 out of 70 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| untranslated.json | Adds untranslated output file for l10n tooling. |
| l10n.yaml | Configures untranslated-messages-file. |
| lib/widgets/report_user_sheet.dart | New report-user bottom sheet UI and submit flow. |
| lib/services/report_service.dart | Simplifies report submission payload (removes message-level reporting). |
| lib/screens/public_profile_screen.dart | Adds “Report user” entrypoint on public profiles. |
| lib/services/presence_service.dart | New WebSocket presence-only service to replace messaging service presence. |
| lib/screens/profile_screen.dart | Removes chats tab and messaging dependencies; uses PresenceService. |
| lib/widgets/profile/profile_tabs.dart | Removes chat callback wiring from friends tab. |
| lib/widgets/profile/profile_friend_tiles.dart | Removes chat icon/action from friend tiles. |
| lib/screens/app_shell.dart | Switches partners page to server list; swaps MessageService for PresenceService; lifecycle foreground hook for tracker. |
| lib/screens/feedback_screen.dart | Stores ticket id and links success state to in-app ticket screen. |
| lib/services/support_service.dart | Removes admin support conversation/message APIs. |
| lib/services/server_directory_service.dart | New HTTP/HttpClient API for directory list/tags/server/vote endpoints. |
| lib/util/directory_server.dart | New directory server/vote/tag models. |
| lib/screens/partner_servers_screen.dart | Removes old partner servers screen. |
| lib/widgets/partner_server_card.dart | Removes old partner server card and status badge UI. |
| lib/widgets/landing/landing_partner_banner.dart | Makes banner open server detail when slug exists; truncates description. |
| lib/widgets/featured_server_hero.dart | Makes hero section navigable to server detail when slug exists. |
| lib/util/partners_servers.dart | Adds optional slug to FeaturedServer JSON model. |
| lib/screens/connector_screen.dart | Removes mapping for Java broadcast mode. |
| lib/widgets/connection/connection_panel.dart | Removes Java mode option and its how-to routing. |
| lib/widgets/navigation/howto_menu.dart | Removes Java how-to tile/callback. |
| lib/widgets/dialogs/howto_dialogs.dart | Removes Java instructions modal. |
| lib/util/howto_prefs.dart | Removes HowToTopic.java. |
| lib/network/broadcast_mode.dart | Removes BroadcastMode.java. |
| lib/theme/app_theme.dart | Removes Java mode color constant. |
| lib/services/server_tracker_service.dart | Adds foreground gating to polling + lifecycle hook support. |
| lib/services/user_service.dart | Bumps terms version string. |
| lib/services/message_service.dart | Removes legacy messaging + presence + conversation APIs. |
| lib/models/message_model.dart | Removes message and conversation models. |
| lib/main.dart | Removes a stray blank import line. |
| lib/l10n/app_en.arb | Updates copy for server list + feedback; removes chat/java strings (but see review comments). |
| lib/l10n/app_de.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_es.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_fr.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_hi.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_id.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_ja.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_nl.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_pt.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_ru.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_sw.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_tr.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_ur.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_zh.arb | Removes chat/java strings; adds server list strings. |
| lib/l10n/app_localizations_ar.dart | Regenerates localization getters for removed/added keys. |
| lib/l10n/app_localizations_de.dart | Regenerates localization getters for removed/added keys. |
| lib/l10n/app_localizations_es.dart | Regenerates localization getters for removed/added keys. |
| lib/l10n/app_localizations_id.dart | Regenerates localization getters for removed/added keys. |
| lib/l10n/app_localizations_nl.dart | Regenerates localization getters for removed/added keys. |
| lib/l10n/app_localizations_pt.dart | Regenerates localization getters for removed/added keys. |
| lib/l10n/app_localizations_zh.dart | Regenerates localization getters for removed/added keys. |
Suppressed comments (2)
lib/services/server_directory_service.dart:65
- fetchVotes() also interpolates slug directly into the URL path. Encoding the slug avoids malformed URLs if the slug ever contains reserved characters.
lib/services/server_directory_service.dart:82 - vote() also interpolates slug directly into the URL path. Encoding the slug prevents malformed URLs / path traversal if an unexpected slug is ever provided.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+73
to
+80
| static void _scheduleReconnect() { | ||
| _connected = false; | ||
| _failCount++; | ||
| _sub?.cancel(); | ||
| _channel = null; | ||
| _reconnectTimer?.cancel(); | ||
| _reconnectTimer = Timer(const Duration(seconds: 5), connect); | ||
| } |
Comment on lines
+51
to
+55
| static Future<DirectoryServer?> fetchServer(String slug) async { | ||
| final body = await _get( | ||
| Uri.parse('${AppConstants.apiBase}/api/servers/$slug?days=30'), | ||
| ); | ||
| final server = body?['server']; |
Comment on lines
47
to
52
| "labelJava": "Java", | ||
| "startJavaMode": "Start Java Mode", | ||
| "javaInfoTitle": "Java Mode", | ||
| "javaInfoText": "Connect to Java Edition servers", | ||
| "howToJavaTitle": "Java Mode", | ||
| "@howToJavaTitle": { | ||
| "description": "Title for the Java how-to modal" | ||
| }, | ||
| "howToJavaSubtitle": "Connect to Java Edition servers via MCCompanion", | ||
| "@howToJavaSubtitle": { | ||
| "description": "Short subtitle for Java menu tile" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.