Skip to content

Main calendar screen: HorizontalPager with per-day swipe navigation#5

Open
Copilot wants to merge 10 commits intomainfrom
copilot/implement-horizontal-pager-for-days
Open

Main calendar screen: HorizontalPager with per-day swipe navigation#5
Copilot wants to merge 10 commits intomainfrom
copilot/implement-horizontal-pager-for-days

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026 •
edited
Loading

  • Modify CalendarScroller.kt to use HorizontalPager (snap-based swipe navigation between days)
  • Sync pager state ↔ ViewModel currentDayIndex
  • Pause all videos when pager drag/swipe starts; resume when it settles
  • beyondBoundsPageCount = 0 — only one page's video composed at a time
  • Prev/next buttons via pagerState.animateScrollToPage
  • snapshotFlow + distinctUntilChanged for pager→ViewModel direction
  • require(days.isNotEmpty()) guard + safe getOrNull/getOrElse access
  • Stable navigateByOffset/onPrevious/onNext via remember
  • Fix build: add missing import androidx.compose.runtime.remember
  • Fix build: add @OptIn(ExperimentalFoundationApi::class) on CalendarScroller and its preview — use Kotlin's built-in kotlin.OptIn (not androidx.annotation.OptIn) so it actually suppresses Kotlin experimental API errors

Copilot AI and others added 6 commits April 3, 2026 22:42
@LukeNeedham
Replace CalendarScroller button navigation with HorizontalPager
1e55208 
- Use HorizontalPager with rememberPagerState for swipe-between-days
- beyondBoundsPageCount=0 so only the current page's video is composed
- LaunchedEffect on isScrollInProgress pauses videos during drag/fling
  and resumes them once the pager settles (uses existing temporaryPause/Resume)
- Two-way sync: pager→ViewModel via LaunchedEffect(currentPage),
  ViewModel→pager (date picker) via LaunchedEffect(currentDayIndex)
- Prev/next buttons animate the pager via animateScrollToPage

Agent-Logs-Url: https://github.com/LukeNeedham/VideoDiary/sessions/e974c16a-349c-47f8-bfd4-bf30a508f4cd

Co-authored-by: LukeNeedham <49884591+LukeNeedham@users.noreply.github.com>
@LukeNeedham
Address code review feedback on CalendarScroller
1e73077 
- Add explanatory comments on both sync LaunchedEffects clarifying
  why the guard prevents any cyclic effect between them
- Use days.getOrElse for bounds-safe current-day lookup
- Extract navigateByOffset helper to deduplicate onPrevious/onNext

Agent-Logs-Url: https://github.com/LukeNeedham/VideoDiary/sessions/e974c16a-349c-47f8-bfd4-bf30a508f4cd

Co-authored-by: LukeNeedham <49884591+LukeNeedham@users.noreply.github.com>
@LukeNeedham
Use getOrNull for safe days access inside pager pages
d190eae 
Also coerce initialPage into days.indices for safe pager initialization

Agent-Logs-Url: https://github.com/LukeNeedham/VideoDiary/sessions/e974c16a-349c-47f8-bfd4-bf30a508f4cd

Co-authored-by: LukeNeedham <49884591+LukeNeedham@users.noreply.github.com>
@LukeNeedham
Make onPrevious/onNext stable with remember; guard empty days in coer…
f4cb146 
…ceIn

- Use remember(pagerState, coroutineScope) for onPrevious/onNext lambdas
  so they are not recreated on every recomposition
- Use pagerState.pageCount (dynamic property on stable pagerState) instead
  of days.indices, avoiding capturing mutable days in the remembered lambdas
- Guard initialPage: use days.isNotEmpty() check before coerceIn(days.indices)

Agent-Logs-Url: https://github.com/LukeNeedham/VideoDiary/sessions/e974c16a-349c-47f8-bfd4-bf30a508f4cd

Co-authored-by: LukeNeedham <49884591+LukeNeedham@users.noreply.github.com>
@LukeNeedham
Extract navigateByOffset helper to deduplicate onPrevious/onNext
a6b4fe2 
Use a single remembered navigateByOffset: (Int) -> Unit lambda,
with onPrevious/onNext as thin stable wrappers via remember(navigateByOffset)

Agent-Logs-Url: https://github.com/LukeNeedham/VideoDiary/sessions/e974c16a-349c-47f8-bfd4-bf30a508f4cd

Co-authored-by: LukeNeedham <49884591+LukeNeedham@users.noreply.github.com>
@LukeNeedham
Add require guard for non-empty days; use snapshotFlow for scroll pau…
0dd5aa3 
…se/resume

- require(days.isNotEmpty()) documents the programming contract and makes
  the days.last() fallback provably safe
- Replace LaunchedEffect(isScrollInProgress) with snapshotFlow so pause/resume
  only fires on actual scroll-state transitions, not at initial composition
- Simplify initialPage back to currentDayIndex.coerceIn(days.indices)

Agent-Logs-Url: https://github.com/LukeNeedham/VideoDiary/sessions/e974c16a-349c-47f8-bfd4-bf30a508f4cd

Co-authored-by: LukeNeedham <49884591+LukeNeedham@users.noreply.github.com>
Copilot AI changed the title [WIP] Add horizontal pager to main page for daily video swiping Main calendar screen: HorizontalPager with per-day swipe navigation Apr 3, 2026
Copilot AI requested a review from LukeNeedham April 3, 2026 22:59
@LukeNeedham LukeNeedham marked this pull request as ready for review April 3, 2026 23:08
LukeNeedham
LukeNeedham requested changes Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@LukeNeedham LukeNeedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the build - there are many build errors

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 4, 2026

Fix the build - there are many build errors

Fixed in f56ec04 — import androidx.compose.runtime.remember was missing from the imports in CalendarScroller.kt.

Copilot AI requested a review from LukeNeedham April 4, 2026 08:58
LukeNeedham
LukeNeedham requested changes Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@LukeNeedham LukeNeedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the build

Task :app:compileDebugKotlin FAILED
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:48:22 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:57:20 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:58:24 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:58:35 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:68:13 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:68:24 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:69:13 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:69:24 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:76:20 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:77:24 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:77:35 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:87:37 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:87:48 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:92:52 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:94:26 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:94:37 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:95:41 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:95:52 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:96:41 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:96:52 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:116:17 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:117:29 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:147:17 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:148:29 This foundation API is experimental and is likely to change or be removed in the future.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 4, 2026

Fix the build

Task :app:compileDebugKotlin FAILED...

Fixed in d05e739 — added @OptIn(ExperimentalFoundationApi::class) (with the matching imports) to both CalendarScroller and its preview function.

Copilot AI requested a review from LukeNeedham April 4, 2026 22:45
LukeNeedham
LukeNeedham requested changes Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@LukeNeedham LukeNeedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix ALL build errors. Ensure project builds.

e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:51:22 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:60:20 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:61:24 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:61:35 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:71:13 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:71:24 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:72:13 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:72:24 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:79:20 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:80:24 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:80:35 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:90:37 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:90:48 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:95:52 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:97:26 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:97:37 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:98:41 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:98:52 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:99:41 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:99:52 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:119:17 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:120:29 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:150:17 This foundation API is experimental and is likely to change or be removed in the future.
e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:151:29 This foundation API is experimental and is likely to change or be removed in the future.

@LukeNeedham
Fix build: use kotlin.OptIn (not androidx.annotation.OptIn) for Exper…
a2df9fc 
…imentalFoundationApi

Agent-Logs-Url: https://github.com/LukeNeedham/VideoDiary/sessions/652c62cb-25bf-4871-b79e-20e781ed4f94

Co-authored-by: LukeNeedham <49884591+LukeNeedham@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 5, 2026

Fix ALL build errors. Ensure project builds.

e: file:///home/runner/work/VideoDiary/VideoDiary/app/src/main/java/com/lukeneedham/videodiary/ui/feature/calendar/component/CalendarScroller.kt:51:22 Thi...

Fixed in a2df9fc — the root cause was using androidx.annotation.OptIn instead of Kotlin's built-in kotlin.OptIn. The androidx variant is for Java-interop annotation processors and does not suppress Kotlin experimental API errors. Removed the import androidx.annotation.OptIn so @OptIn now resolves to kotlin.OptIn, which correctly opts into ExperimentalFoundationApi.

Copilot AI requested a review from LukeNeedham April 5, 2026 11:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

✅ Debug APK build complete!

Download the APK from the workflow run artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukeNeedham LukeNeedham Awaiting requested review from LukeNeedham

Assignees

@LukeNeedham LukeNeedham

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LukeNeedham