Improvement in common module - #56
Open
DebanKsahu wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
I did some memory and performance improvement during going through the common module code.
LoggingOptions,CheckOptions,DeclarationCounts,FilterandPatternMatchingOptionsclasses now usingslots-Trueoptions to reduce memory of objects.code_declarations()function which now only take 2 iteration (one throughast.walk(tree)which do complete walk and the second one is throughast.bodywhich do a module level walk) to calculate module level functions, instance, class and nested classes. There is no need of_is_module_level()function for now.Change Type
Validations
uv run pytestsuccessful with 100%uv run ruff check src/All check passeduv run mypy src/archunitpython/All check passed