fix(pflash): score the user query and reject non-finite scores - #679
Draft
Graffioh wants to merge 3 commits into
Draft
fix(pflash): score the user query and reject non-finite scores#679Graffioh wants to merge 3 commits into
Graffioh wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DFLASH_COMPRESS_QUERY_TOKENS, which remains the lexical-anchor windowWhy
The previous fixed
lookahead=8window landed on the rendered assistant suffix rather than on the question. On Strix Halo/gfx1151, corrupted HIP forward values could also reach the scorer; NaN comparisons then left earlier maxima in place and silently produced a selection.Validation
Luce-Org/lucebox@ef82fadfgfx1151:dflash_server,test_tokenizer_harness, andtest_server_unitHIP_VISIBLE_DEVICES=1 ./build-hip-gfx1151/test_server_unit: 439 passed, 0 failed[16374, 16382), rather than the rendered assistant suffixThe underlying gfx1151 numeric corruption is intentionally not hidden by this PR; this makes it observable and prevents quality results from being reported from invalid scores.
Paired long-context benchmark campaign: Luce-Org/luce_box#85.