feat(server): integrate Ling 3 Flash on DGX Spark - #661
Conversation
|
d1fbe58 to
d7b4795
Compare
There was a problem hiding this comment.
All reported issues were addressed
You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="server/src/bailingmoe3/bailingmoe3_graph.cpp">
<violation number="1" location="server/src/bailingmoe3/bailingmoe3_graph.cpp:57">
P0: The Ling backend never executes either builder in this file. Route `BailingMoe3Backend` through these builders (and the corresponding Ling FFN/cache graph) before shipping, otherwise `bailingmoe3` models use the incompatible Qwen3.5 graph instead of the native implementation.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| // absorption through attn_k_b turns the 128 non-RoPE Q dimensions into the | ||
| // same latent space, and attn_v_b expands the attention result back to 128 | ||
| // value dimensions per head. | ||
| ggml_tensor * build_bailingmoe3_mla_block( |
There was a problem hiding this comment.
P0: The Ling backend never executes either builder in this file. Route BailingMoe3Backend through these builders (and the corresponding Ling FFN/cache graph) before shipping, otherwise bailingmoe3 models use the incompatible Qwen3.5 graph instead of the native implementation.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At server/src/bailingmoe3/bailingmoe3_graph.cpp, line 57:
<comment>The Ling backend never executes either builder in this file. Route `BailingMoe3Backend` through these builders (and the corresponding Ling FFN/cache graph) before shipping, otherwise `bailingmoe3` models use the incompatible Qwen3.5 graph instead of the native implementation.</comment>
<file context>
@@ -0,0 +1,249 @@
+// absorption through attn_k_b turns the 128 non-RoPE Q dimensions into the
+// same latent space, and attn_v_b expands the attention result back to 128
+// value dimensions per head.
+ggml_tensor * build_bailingmoe3_mla_block(
+ ggml_context * ctx,
+ ggml_cgraph * gf,
</file context>
|
Addressed all four valid Cubic findings in the current head ( The reported P0 about the Ling builders is a false positive: The exact head builds on DGX Spark ( |
Summary
bailingmoe3loading and serving for Ling 3.0 Flashsrc/bailingmoe3moduleScope
This PR is intentionally limited to the native model integration:
The previously validated performance work is preserved separately on
codex/ling3-flash-performancefor focused follow-up review.Validation
Validated from commit
e49abacon an NVIDIA DGX Spark / GB10 (sm_121):test_server_unitcases passedgit diff --checkpassedModel
bailingmoe3(the GGUF architecture identifier)