Skip to content

Finish performance traces on handler exceptions #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LordSimal merged 2 commits into from
Aug 9, 2026
Merged

Finish performance traces on handler exceptions #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe3b1de
Finish performance traces on handler exceptions
LordSimal Aug 9, 2026
57b153e
Merge 3.x into performance exception cleanup
LordSimal Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Middleware/CakeSentryPerformanceMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use CakeSentry\Database\Log\CakeSentryLog;
use CakeSentry\Event\CacheEventListener;
use CakeSentry\Event\HttpEventListener;
use CakeSentry\DebugTimer;

Check failure on line 22 in src/Middleware/CakeSentryPerformanceMiddleware.php

View workflow job for this annotation

GitHub Actions / Coding Standard & Static Analysis 

Use statements should be sorted alphabetically. The first wrong one is CakeSentry\DebugTimer.
use CakeSentry\EventListener;
use CakeSentry\QuerySpanTrait;
use Psr\Http\Message\ResponseInterface;
Expand All @@ -28,8 +28,10 @@
use Psr\Http\Server\RequestHandlerInterface;
use Sentry\SentrySdk;
use Sentry\Tracing\SpanContext;
use Sentry\Tracing\SpanStatus;
use Sentry\Tracing\TransactionContext;
use Sentry\Tracing\TransactionSource;
use Throwable;
use function Sentry\startTransaction;

/**
Expand Down Expand Up @@ -116,6 +118,16 @@
}

return $response;
} catch (Throwable $exception) {
$span
->setStatus(SpanStatus::internalError())
->finish();
SentrySdk::getCurrentHub()->setSpan($transaction);
$transaction
->setStatus(SpanStatus::internalError())
->finish();

throw $exception;
} finally {
$eventManager->off($listener);
$eventManager->off($httpListener);
Expand Down
Loading