Repository navigation
fix: correct mobile new-chat controls and repair preview runtimes - #1997
Merged
Merged
Conversation
zxch3n
force-pushed
the
fix/mobile-branch-label
branch
from
October 28, 2026 04:42
a9abaa2 to
7dd501f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Follow-up to #1983 (merged).
Problem / pressure
Mobile new chat showed an internal selector such as
lody:branch:local:mainin the branch row when worktree was off. That path displayed the directory's current ref directly, bypassing the existing formatter. The story used plain branch names and did not expose this state. The GitHub owner avatar also sat 2.5px above the project label: its inline-flex frame introduced baseline space inside the trigger's icon slot.Summary
Use one display resolver for the checked-out branch in direct local mode and the selected base branch in worktree mode. Both format local/remote selectors through the existing label formatter; launch values remain unchanged. GitHub branch names stay verbatim. Update the real-component story to use encoded local selectors and exercise switching worktree off and back on. Use block flex layout for the shared owner-avatar frame so both themes align the avatar with the project text while loading, after loading and in expanded options.
Main supplies the onboarding tour subscription and its regression test through #2001. This PR preserves that implementation and adds the matching frozen read subscription to the conversation Storybook runtime.
Visual explanation
Before / after
lody:branch:local:mainmain (local)(localized suffix)Real-component screenshots use synthetic workspace data. No user recording or device screenshot is uploaded.
Test plan
1ce6a72c9; main's onboarding fix, mobile page entrance/edge-back behavior and scheduled-send changes are preserved. The first three original patches remain equivalent undergit range-diff; the last drops duplicate upstream tour changes and retains the conversation-story fix.git diff --checkpass. Rootpnpm checkstops at CLI typecheck because ACP extension modules are uninitialized; docs validation reports 88 existing missing-submodule link errors and no errors in changed docs.0.107.2 (20261028.8)was built, signed, installed and launched on the physical iPhone from the documented isolated native/cloud dependency baseline. It was not rebuilt for this rebase, and does not establish device acceptance of the rebased main features. New full desktop smoke results are tracked against the pushed PR head.