build(windows): add arm64 build - #420
Merged
Merged
Conversation
|
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
A Good news for everyone who care this. All Works is Done!!!
Today progress
See commits for details In addition, I pinned the CMake version of CI to 3.31.2, which can temporarily solve the problem of Windows CI build failure. Thanks to everyone who reads here, have a nice day! |
rbqvq
marked this pull request as ready for review
May 11, 2025 16:16
rbqvq
changed the title
Contributor
Author
|
Here is CI artifacts https://github.com/rbqvq/build-deps/actions/runs/14957436940/artifacts/3101752802 |
ReenigneArcher
left a comment
ReenigneArcher
left a comment
Member
There was a problem hiding this comment.
Thanks for updating the PR!
It looks pretty good but I do have a few comments and questions.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Windows 11 Arm64 runners don't like x86_64 runners have two disk, they're only one disk C:
Replace hardcoded path `/d/a/_temp/` to `${{ runner.temp }}` and use `MSYS2_ROOT` environment variables
Signed-off-by: Coia Prant <coiaprant@gmail.com>
Add initial clangarm64 support for Windows Arm64 builds Signed-off-by: Coia Prant <coiaprant@gmail.com>
MSYS2 CLANGARM64 is native arm64 binary, can not run on non-arm64 hosts. Signed-off-by: Coia Prant <coiaprant@gmail.com>
Apple should be reported as darwin Win32 should be reported as mingw64 Signed-off-by: Coia Prant <coiaprant@gmail.com>
This is a temporary solution to fix the issue with Windows Arm64 not being recognized correctly in x264 `uname -m` is currently reported as `x86_64` instead of `aarch64` in MSYS2 Link: msys2/msys2-runtime#171 x264 `config.guess` uses `uname -m` to detect architecture Link: https://code.videolan.org/videolan/x264/-/tree/1ecc51ee971e0056a53bd6cf9c6f6af18b167e4b/config.guess#L809 Signed-off-by: Coia Prant <coiaprant@gmail.com>
This is a temporary solution to fix the issue with Windows Arm64 not being recognized correctly in FFmpeg `uname -m` is currently reported as `x86_64` instead of `aarch64` in MSYS2 Link: msys2/msys2-runtime#171 FFmpeg `configure` uses `uname -m` to detect architecture Link: https://github.com/FFmpeg/FFmpeg/blob/4e5523c98597a417eb43555933b1075d18ec5f8b/configure#L4161 Signed-off-by: Coia Prant <coiaprant@gmail.com>
FFmpeg `configure` will disable ffnvcodec on Windows Arm64 Link: https://github.com/FFmpeg/FFmpeg/blob/4e5523c98597a417eb43555933b1075d18ec5f8b/configure#L7443 This problem may be solved in 2026 (NVIDIA and MediaTek release Windows Arm computers) Until FFmpeg fixes this, disable them first Signed-off-by: Coia Prant <coiaprant@gmail.com>
Add CI build for Windows ARM64 target Signed-off-by: Coia Prant <coiaprant@gmail.com>
Add windows arm64 build guide with notes Signed-off-by: Coia Prant <coiaprant@gmail.com>
Some packages are not compatible with the latest MSYS2 version, because it bundles CMake 4.0 Pinned the MSYS2 version and disabled updates back to CMake 3.31.2 until the following issues are resolved Link: #414 Signed-off-by: Coia Prant <coiaprant@gmail.com>
# Conflicts: # .github/workflows/ci.yml
ReenigneArcher
enabled auto-merge (squash)
May 23, 2025 23:11
ReenigneArcher
disabled auto-merge
May 23, 2025 23:31
ReenigneArcher
changed the title
ReenigneArcher
enabled auto-merge (squash)
May 23, 2025 23:31
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since GitHub add Windows 11 Arm64 runners, we can prepare Sunshine for ARM64
Let's add windows arm64 builds
Screenshot
None
Issues Fixed or Closed
None
Type of Change
.github/...)Checklist
Status
PassedPassedChanges
TL;DR. See commits
Do not need approve workflows, it will failed before known issues resolved
After this ready, we can back to LizardByte/Sunshine#3369