Skip to content

Three Windows builds are keyed on a later release than their layout #191

Closed

Description

@ero-qt

Three entries in the Windows tables point at a later release than the one where their layout first shows up:

Table Entry First release with the layout How I checked
mono/builds.rs 2017.1.0f3 (2017.1.0.9747), x64 and x86 2017.1.0f1 (2017.1.0.32737) the mono-2.0-bdwgc.dll in 2017.1.0f1 has the same debug IDs
il2cpp/builds.rs 2018.2.0f2 (2018.2.0.30296), x64 and x86 2018.2.0f1 (2018.2.0.44229) the 2018.2.0f1 GameAssembly.pdb gives the same offsets
il2cpp/builds.rs 2019.1.0f2 (2019.1.0.11155), x64 and x86 2019.1.0f1 (2019.1.0.21026) the 2019.1.0f1 GameAssembly.pdb gives the same offsets

Nothing picks the wrong build because of this, since nearest only looks at the patch. I'd still like each entry to sit on the first release that has its layout, so the table reads the same way everywhere.

I'd move the 3 entries to their f1 release and rename the 6 profile constants that have the old release in them, like UNITY_2018_2_0F2_X86_64. #187 did the same renames without keeping aliases.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions