Repository navigation
Conversation
|
Review complete. No issues found — approved ✅. This change keeps agent-generated scratch directories and experiment result artifacts out of the published crate. Both files that list repository-only paths were updated in lockstep:
Reviewed commit: e2269f2 |
|
| Status | Commit | Started (UTC) | Finished (UTC) |
|---|---|---|---|
| ✅ Incremental review completed | e6d6d00 |
Oct 26, 2026 · 03:14 | 03:15 |
| ✅ Reviewed your PR | e2269f2 |
Oct 25, 2026 · 12:12 | 12:14 |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR makes two tightly coupled changes:
Cargo.toml— adds.agents/andexperiments/usefulness/results/to[package] exclude, preventing those paths from being included in the published.cratearchive..github/scripts/qualify-package.py— mirrors those exclusions in theREPOSITORY_ONLYtuple, so the CIpackagejob will fail fast if they ever reappear in the packaged file list.
Both changes are consistent with each other and with the rest of the codebase. The startswith-based check in check_package_list correctly handles the trailing-slash convention used for all entries. No logic errors, security issues, or correctness defects were found. The PR is ready to merge pending the CI package job result.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
codeant-ai
Bot
added
the
size:XS
|
Caution Review failedThe pull request is closed. No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Exclude repository-only paths Cargo.toml, .github/scripts/qualify-package.py |
Both package exclusion mechanisms add .agents/ and experiments/usefulness/results/. Existing Cargo exclusions remain unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related issues
- release: coordinate corpus-ipc v0.2.0 structured transport and correctness corpus-ipc#43: The issue's package qualification and package-list checks align with this PR's packaging exclusions.
Possibly related PRs
- Limen-Neural/brainstem-daemon#102: It updates package qualification and packaging configuration in the same files.
- Limen-Neural/brainstem-daemon#97: It adds a Cargo package exclusion that remains in the list extended by this PR.
Suggested labels: GItHub Actions
Suggested reviewers: codescene-access
Merge Risk: 
e2269
-
The package exclusion changes are aligned for the repository paths affected by this PR.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies the package exclusion cleanup, which is the main implemented change. The Rust upgrade wording is slightly inaccurate because the audit found that Rust 1.99.0 was already c… Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description check The pull request description directly matches the changeset. It explains the Rust pin audit and the exclusion of .agents/ and experiments/usefulness/results/ from the Cargo package and qualification c… Full details: Title check
-
Explanation
The title clearly identifies the package exclusion cleanup, which is the main implemented change. The Rust upgrade wording is slightly inaccurate because the audit found that Rust 1.99.0 was already configured, but it remains related to the stated objective.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Full details: Description check
-
Explanation
The pull request description directly matches the changeset. It explains the Rust pin audit and the exclusion of .agents/ and experiments/usefulness/results/ from the Cargo package and qualification checks.
-
Finishing Touches
-
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Rust |  |
Oct 26, 2026 3:14a.m. | Review ↗ |
| Secrets | |
Oct 26, 2026 3:14a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "AGENTS.md", | ||
| "CLAUDE.md", | ||
| "REVIEW.md", | ||
| "Dockerfile", | ||
| ".codacy.yml", | ||
| ".deepsource.toml", | ||
| "docs/", | ||
| "experiments/usefulness/results/", | ||
| ] | ||
|
|
||
| [package.metadata.docs.rs] |
There was a problem hiding this comment.
Bug: Excluding experiments/usefulness/results/ from the package leaves a broken relative link in experiments/usefulness/REPORT.md within the packaged .crate.
Severity: LOW
Suggested Fix
Update the relative link in experiments/usefulness/REPORT.md to point to an absolute GitHub repository URL, or exclude REPORT.md alongside the results directory in Cargo.toml.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: Cargo.toml#L17-L31
Potential issue: Adding `experiments/usefulness/results/` to the package `exclude` list
in `Cargo.toml` leaves `experiments/usefulness/REPORT.md` inside the published crate
while stripping the target directory. As a result, the relative link
`[results/d3f369320b226223644284952b9f60f732175480/](results/d3f369320b226223644284952b9f60f732175480/)`
in `REPORT.md` becomes a dead link when browsing the packaged `.crate` contents.
Also affects:
.github/scripts/qualify-package.py:31-38
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Fixed in 64e8c4c — the REPORT.md results link now points at the GitHub tree URL, so it stays valid inside the packaged crate. REPORT.md itself stays in the package since it documents the measured run.
Generated by Claude Code
![tenki-reviewer[bot]](https://avatars.githubusercontent.com/in/2900641?s=60&v=4){kind=small}
CodeAnt PR Risk: Low Risk
Assessed commit: |
|
Review complete. No new findings in these changes — approved ✅. Reviewed the latest changes. This incremental delta changes only
Reviewed commit: 64e8c4c |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Superseded by a newer Tenki approval on this pull request.
…514) Every Rust pin site (Cargo.toml rust-version, rust-toolchain.toml, all four ci.yml toolchain strings, qualify-package.py `cargo +1.99.0`, Dockerfile FROM tag, .devin/blueprint.yaml, README/AGENTS/REVIEW/docs prose) was already on 1.99.0, so no toolchain change is needed. `cargo package --list` showed the crate shipping `.agents/setup` (the Cursor Cloud bootstrap script) and ~1.9 MiB of committed experiment result logs/gzipped traces under `experiments/usefulness/results/`. Exclude both and teach the package qualification gate to reject them. PROTOCOL.md, run.sh, fixtures, and the examples that consume them stay packaged; `.cargo/config.toml` stays because the extracted package needs its libzmq alignment defines. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWFCFspAvzEAq45Azy9eGS
… excluded from the crate (LIM-1514) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWFCFspAvzEAq45Azy9eGS
64e8c4c to
e6d6d00
Compare
There was a problem hiding this comment.
Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
User description
What / why
Rust pin audit: the repo is already on 1.99.0 everywhere, so no toolchain pin changed. Verified sites:
Cargo.tomlrust-versionrust-toolchain.tomlchannel.github/workflows/ci.ymltoolchain:(4 jobs: fmt, stub, corpus-ipc, package).github/scripts/qualify-package.pycargo +1.99.0/rustc +1.99.0DockerfileFROM rust:1.99.0-bookworm.devin/blueprint.yamlrustup install/defaultREADME.md,AGENTS.md,CLAUDE.md,REVIEW.md,docs/ci.md,experiments/usefulness/run.shNo
.devcontainer/or.cursor/directory exists. The only remaining1.98.1strings are in committedexperiments/usefulness/results/*andREPORT.md, which intentionally record the historical run that produced them (REPORT.md says so explicitly).Package exclusion cleanup (
cargo package --list --allow-dirty): the crate was shipping.agents/setup(Cursor Cloud bootstrap script: apt-get + rustup), andexperiments/usefulness/results/(per-run logs,.jsonl.gztraces, summaries).Both are now in
[package] exclude, andREPOSITORY_ONLYinqualify-package.pyrejects them so the CIpackagejob fails if they come back. Kept in the package:experiments/usefulness/{PROTOCOL.md,REPORT.md,run.sh,summarize.py,config/,fixtures/}(theusefulness_*examples read those fixtures),.cargo/config.toml(the extracted package needs its libzmq alignment defines; see the comment inqualify-package.py),Cargo.lock(binary crate;--lockedis the documented workflow), both licenses,README.md,rust-toolchain.toml.Package list: 62 files after this change; zero
.agents/orresults/entries.How verified (Rust 1.99.0, Linux, CPU only)
cargo fmt --check— cleancargo clippy --locked --all-targets -- -D warnings— cleancargo test --locked— 159 passed, 1 ignored;config_startuppassedRUSTDOCFLAGS="-D warnings" cargo doc --locked --no-deps— cleanCC=gcc CXX=g++ cargo clippy --locked --all-targets --all-features -- -D warnings— clean (libzmq built from source)CC=gcc CXX=g++ cargo test --locked --all-features— 182 passed, 1 ignored;config_startup,thalamic_brainstem_smoke,pub_lifecyclepassedpython3 -m py_compile .github/scripts/qualify-package.py— ok (fullqualify-package.pynot run locally; it needs a clean committed checkout and runs a publish dry-run; the CIpackagejob covers it)Acceptance checklist
[package] excludeaudited viacargo package --list; agent/CI/devin files and bulky result artifacts excluded; license/README/fixtures included-D warnings, tests (stub +--all-features), rustdoc-D warningsgreen on 1.99.0packagejob (publish dry-run) — runs in GitHub Actions on this PROut of scope: publishing, consumer bumps, edition/API changes.
Closes LIM-1514
Generated by Claude Code
<source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v3.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3-3x.png" width="162" height="28">https://backend.blacksmith.sh/track/enable-autofix?expires=1795522358&installation_model_id=442967&pr_number=104&ref=codesmith_pr_footer&repository=Limen-Neural%2Fbrainstem-daemon&return_to=https%3A%2F%2Fgithub.com%2FLimen-Neural%2Fbrainstem-daemon%2Fpull%2F104&signature=f00005541ba8127f0cbc07cbe7e7a193512e646bcc00cdcaba2a8572c32a27dd"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png" width="190" height="28">Need help on this PR? Tag
@codesmith-botwith what you need.Generated by Claude Code
CodeAnt-AI Description
Exclude setup scripts and experiment results from published crates
What Changed
Impact
✅ Smaller crate downloads✅ No repository setup script in published crates✅ Experiment results remain accessible on GitHub💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.