[rmems]

User description

Summary

Bump the brainstem-daemon minimum Rust version from 1.98.1 to 1.99.0 at every live pin site. That matches axon-encoder, synaptic-wiring, and corpus-ipc on main (Limen-Neural/corpus-ipc#57, merged). Published crates.io corpus-ipc 0.1.0 still declares rust-version 1.98.1, so this pull request does not change that dependency.

Closes #98

Relationships

• Parent: none
• Blocked by: none
• Blocks: none
• Related: open dependency pull requests build(deps): bump toml from 0.8.23 to 1.1.8+spec-1.1.0 #99, build(deps): bump sha2 from 0.11.0 to 0.11.1 #100, and build(deps): bump dirs from 5.0.1 to 7.0.0 #101 also edit Cargo.toml or Cargo.lock. They change dependency versions, and this pull request does not.

What changed

• Pins: Cargo.toml rust-version, rust-toolchain.toml, every CI toolchain: string, Dockerfile, .devin/blueprint.yaml, README.md, REVIEW.md, AGENTS.md, CLAUDE.md, docs/ci.md, and .github/scripts/qualify-package.py.
• FakeClock::advance calls AtomicU64::try_update. Rust 1.99 deprecates fetch_update, and clippy -D warnings rejects the old name.
• The usefulness runner and its reproduction commands follow the new pin. Recorded results stay on the Rust 1.98.1 toolchain that measured them.

Out of scope

• No dependency bumps and no new crates.
• No crates.io publish.
• Recorded usefulness results are not re-run.

Verification

Local Rust 1.99.0 (rustc 1.99.0 (b940084d7 2026-09-28)):

• cargo fmt --check
• cargo clippy --locked --all-targets -- -D warnings
• cargo test --locked (159 passed, 1 ignored, plus config_startup)
• CC=gcc CXX=g++ cargo clippy --locked --all-targets --all-features -- -D warnings
• CC=gcc CXX=g++ cargo test --locked --all-features (182 passed, 1 ignored, plus config_startup, pub_lifecycle, thalamic_brainstem_smoke)
• RUSTDOCFLAGS="-D warnings" cargo doc --locked --no-deps with and without --all-features

  

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Bumps the minimum Rust version from 1.98.1 to 1.99.0 across all live pins so the daemon matches axon-encoder, synaptic-wiring, and corpus-ipc on main. Published corpus-ipc 0.1.0 still declares 1.98.1, but this pin can build it.

• Updates Cargo.toml, rust-toolchain.toml, CI workflow, Dockerfile, .devin/blueprint.yaml, package qualification, and related docs.
• Replaces AtomicU64::fetch_update with try_update in the test clock because 1.99 deprecates the old name.

^{Written for commit 7925d1b. Summary will update on new commits.}

---

CodeAnt-AI Description

Require Rust 1.99.0 to build the daemon

What Changed

• Raises the minimum supported Rust version from 1.98.1 to 1.99.0 across project builds and release checks.
• Aligns the daemon with the Rust version used by axon-encoder, synaptic-wiring, and corpus-ipc on main. Published corpus-ipc 0.1.0 remains buildable.

Impact

✅ Builds with the current neural-stack toolchain
✅ Consistent Rust version across local, CI, and Docker builds

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai]

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	7925d1b	Oct 24, 2026 · 04:23	04:25

[codeant-ai]

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[coderabbitai]

Caution

Review failed

The pull request is closed.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

✨ Simplify code

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[amazon-q-developer]

Review Summary

This PR performs a consistent MSRV bump from Rust 1.98.1 to 1.99.0 across all 15 pin sites: Cargo.toml, rust-toolchain.toml, CI workflow toolchain steps, Dockerfile base image, .devin/blueprint.yaml, qualify-package.py, run.sh, and documentation files.

The one functional code change — replacing AtomicU64::fetch_update with AtomicU64::try_update in FakeClock::advance (src/health/clock.rs) — is correct. Both APIs accept (success_ordering, failure_ordering, FnMut(T) -> Option<T>), the closure always returns Some(...), and the Result return value is intentionally discarded via let _ =, making the behavior semantically identical to the removed call.

No logic errors, security vulnerabilities, crashes, or missing error handling were found. All changes are consistent and correctly scoped to the declared intent. No blocking issues identified — this PR is good to merge.

---

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

[codacy-production]

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category	Results
Comprehensibility	1 minor

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[codescene-access]

Gates Passed
6 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

[deepsource-io]

DeepSource Code Review

We reviewed changes in 6bf26dc...7925d1b on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade

Security   Reliability   Complexity   Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
Rust		Oct 24, 2026 4:23a.m.	Review ↗
Secrets		Oct 24, 2026 4:23a.m.	Review ↗

---

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

[rmems]

Closing as a duplicate of #102, which covers #98.

Cited by: Provenance Architect (Grok Bot)