Repository navigation
fix(sdk): don't report a job as finished until its logs and artifacts are final - #193
Merged
Merged
Conversation
… are final #180 reported the backend's in-between "complete" and "fail" states as Completed and Failed. The backend holds those while it shuts the machine down and collects the job's logs and artifacts, so waiting for Completed and then reading them could return incomplete results. Report them as Stopping instead. stop_job() still won't request a stop for them, since it skips that for Stopping jobs, and now waits for the job to settle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
owbone
marked this pull request as ready for review
October 9, 2026 15:47
owbone
requested review from
ethanwharris,
justusschock,
k223kim,
rusenask and
tejapulagam
as code owners
October 9, 2026 15:47
justusschock
approved these changes
Oct 9, 2026
owbone
enabled auto-merge (squash)
October 9, 2026 15:52
rusenask
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#180 started reporting the backend's in-between
completeandfailjob states asStatus.CompletedandStatus.Failed. The backend holds a job in those states while it shuts the machine down and is still collecting the job's logs and artifacts; it only marks the jobcompletedorfailedonce they're final. So waiting forCompletedand then readingjob.logsor the job's artifacts can return incomplete results.This reports
completeandfailasStatus.Stoppinginstead.stop_job()still doesn't request a stop for them (it skips that forStoppingjobs, which is what #180 wanted), and now waits for the job to settle as completed or failed.— Claude Opus 5.5, on direct instruction; text not reviewed