Fix device token handling - #38
Merged
Merged
Conversation
tiankaima
marked this pull request as ready for review
August 11, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
openid,profile, andemailidentity scopesoffline_accessand all discovered API feature scopesid_tokengo-josedependencyRoot cause
The production RFC 8628 device token response correctly contains access/refresh tokens and granted scopes but no OIDC ID token. The CLI does not consume identity claims, yet it requested
openidand rejected the otherwise valid OAuth response whenid_tokenwas absent. Its old parser also inspected ID-token claims without signature verification, so retaining that unused path provided no security value.Impact
life-ustc account login --devicenow saves the issued OAuth credentials after approval. Browser login uses the same API/offline scope set and no longer depends on an unused OIDC response.Validation
id_tokengo test ./internal/authgo test -race ./...go vet ./...golangci-lint run ./...go build -buildvcs=false -ldflags "-X github.com/Life-USTC/CLI/internal/cmd/root.version=dev" -o life-ustc ./cmd/life-ustc